John Scudder has entered the following ballot position for
draft-ietf-bess-evpn-lsp-ping-10: No Objection

When responding, please keep the subject line intact and reply to all
email addresses included in the To and CC lines. (Feel free to cut this
introductory paragraph, however.)


Please refer to 
https://www.ietf.org/about/groups/iesg/statements/handling-ballot-positions/ 
for more information about how to handle DISCUSS and COMMENT positions.


The document, along with other ballot positions, can be found here:
https://datatracker.ietf.org/doc/draft-ietf-bess-evpn-lsp-ping/



----------------------------------------------------------------------
COMMENT:
----------------------------------------------------------------------

Thanks for this update, I've cleared my DISCUSS.

I do think there is a little further improvement possible. The new text is
adequate, so please use your own judgment, but my suggestion would be something
like the following, using RFC 9136 Section 3.1 as a model. This adds a MUST,
some parentheses, and a comma, and drops an "as". Other than the MUST the
changes are just stylistic.

OLD:
   The EVPN IP Prefix Sub-TLV has the format as shown in Figure 4.  The
   total length of this sub-TLV can be either 32 bytes if IPv4 addresses
   are carried or 56 bytes if IPv6 addresses are carried. The IP prefix
   and gateway IP address MUST be from the same IP address family as
   described in Section 3.1 of [RFC9136].

NEW:
   The EVPN IP Prefix Sub-TLV has the format shown in Figure 4.  The
   total length (not shown) of this sub-TLV MUST be either 32 bytes (if
   IPv4 addresses are carried) or 56 bytes (if IPv6 addresses are carried).
   The IP prefix and gateway IP address MUST be from the same IP address
   family, as described in Section 3.1 of [RFC9136].

and,

OLD:
   *  The IP prefix field is set to a 4-octet IPv4 address (with
      trailing 0 bits to make 32 bits in all) or 16-octet IPv6 address
      (with trailing 0 bits to make 128 bits in all).

   *  The Gateway (GW) IP Address field is set to a 4-octet IPv4 address
      or 16-octet IPv6 address if it's used as an Overlay Index for the
      IP prefixes.  If the GW IP Address is not being used, it must be
      set to 0 as described in Section 3.1 of [RFC9136].

NEW:
   *  The IP prefix field is set to a 4-octet IPv4 address (with
      trailing 0 bits to make 32 bits in all) or 16-octet IPv6 address
      (with trailing 0 bits to make 128 bits in all). The address family
      of this field is inferred from the sub-TLV length field, as
      discussed above.

   *  The Gateway (GW) IP Address field is set to a 4-octet IPv4 address
      or 16-octet IPv6 address if it's used as an Overlay Index for the
      IP prefixes.  If the GW IP Address is not being used, it must be
      set to 0 as described in Section 3.1 of [RFC9136]. The address
      family of this field is inferred from the sub-TLV length field, as
      discussed above.

I proposed the additional sentence in the two bulleted text items because,
without that, there's no description *in the bullet list* of how to infer the
address family, unlike RFC 9136 which does provide this context in the bullet
list. In my experience, people referring to the document quickly can't
necessarily be relied upon to carefully read the entire section. :-(



_______________________________________________
BESS mailing list
[email protected]
https://www.ietf.org/mailman/listinfo/bess

Reply via email to