Dan Sully wrote: > * Christopher Key shaped the electrons to say... > >> However, having done some further testing, I was misunderstanding >> what exactly was going on on line 1448. The tracks do all appear to >> add correctly even if non contiguous. I still don't understand the >> logic behind lines 1477 to 1489, specifically why a match on discc >> is only attempted if discc > 1, otherwise a match is attempted for >> disc and discc both NULL. > > Often (bug 3662), people don't add a DISCC value to their music. > > The other case, bug: 3254 - a user had: > > AC/DC - Live > AC/DC - Live (Disc 1 of 2) > AC/DC - Live (Disc 2 of 2) > > So one is defeated on any title matching alone because it's a common > title, and two, because of an album of the same name by the same > artist but with different disc & discc values.
Ok, maybe I'm still missing something. It just seems a bit strange to attempt to match discc if a user has set discc = 2,3,4 etc. but to search for 'disc is NULL AND discc is NULL' if the user has set discc = 1. Likewise, it seemed a bit strange to search for 'disc is NULL AND discc is NULL' if discc hadn't been set, regardless of what the user has set for disc. Chris _______________________________________________ beta mailing list [email protected] http://lists.slimdevices.com/lists/listinfo/beta
