Matt Kreiner;131576 Wrote: > I noticed that when a file has embedded ID3v1 and ID3v2 tag info, should > there be any discrepancy between the "Comment" field in the ID3 tags > there is the likelihood that a song or album may be listed more than > one time. Deleting the content of the comment field corrects the > listing in the slimserver web interface. > > I haven't filed a bug yet, but wanted to pass it along for some > investigation. Maybe an option is to disregard the comment field > altogether?
This surprises me slightly as my understanding of the MP3/ID3v2/ID3v1 handling was that if there was ID3v2 information it would be used (and ID3v1(.1) would be ignored), and only if only ID3v1(.1) was present would it be used as it is. Checking against revision 9217, indicates that I'm right in my understanding - see Slim/Formats/MP3.pm lines 129-133 which only reads v2 tags if they're present and then falls back to v1 if no v2 tags are there. So, I'm a little confused as to how you could see the v1 tags affecting the v2 ones. If you could trim such a file which is giving you a problem it might be possible to diagnose why it has processed both v2 and v1 when the code path should not allow that (at least not as I understand it). Matt Kreiner;131576 Wrote: > Also, I've seen this similar thing with odd characters in the ID3v1 > comment field, such as a carriage return character, etc This may be fixed by the small tidy up patch I did in a separate thread for the multi-value text fields. I noticed at the time that I made the changes for multi-value text fields that the ID3v1 fields may remain padded with values and unstripped, so the strings would be padded with spaces or nuls (or in your case CRs) which would then fail to match with the ID3v2 data (that is, 'U2' padded to 30 characters with nuls is not equal to 'U2' with no padding). This additional matching is not used by SlimServer (it's only used when an unspecified tag type is requested), but the change to strip the ID3v1 fields may be useful to reduce the content to its useful size. -- gerph ------------------------------------------------------------------------ gerph's Profile: http://forums.slimdevices.com/member.php?userid=1819 View this thread: http://forums.slimdevices.com/showthread.php?t=26785 _______________________________________________ beta mailing list [email protected] http://lists.slimdevices.com/lists/listinfo/beta
