To someone from Logitech:
- Should we just ignore problems that have been fixed in onebrowser
even if it actually hasn't anything to do with onebrowser or do you
want us to register bug reports for these too, even if they are already
fixed in the onebrowser branch ?
I'm asking because the following patch would fix an issue with context
menus which aren't properly hiding elements on IP3K devices in trunk,
it's already been applied to onebrowser branch but not in trunk. I
guess it's safe to ignore this if you are sure onebrowser branch will
be the one released as 7.6, but if you aren't sure I'd appreciate if
you consider applying this to trunk as it cause problem for one of my
plugins.
The issue is that the previously used "for my $item ()" construct
doesn't work reliably when you modify the contents of the array inside
the loop. In this case splice is called inside the loop in some cases.
Code:
--------------------
Index: Slim/Buttons/XMLBrowser.pm
===================================================================
--- Slim/Buttons/XMLBrowser.pm (revision 32342)
+++ Slim/Buttons/XMLBrowser.pm (working copy)
@@ -444,8 +444,8 @@
my $radioDefault;
- my $index = 0;
- for my $item ( @{ $opml->{'items'} || [] } ) {
+ for (my $index = 0; $index < scalar @{ $opml->{'items'} || []}; ) {
+ my $item = $opml->{'items'}->[$index];
# Add value keys to all items, so INPUT.Choice remembers state properly
if ( !defined $item->{'value'} ) {
--------------------
--
erland
Erland Isaksson ('My homepage' (http://erland.isaksson.info))
(Developer of 'many plugins/applets'
(http://wiki.slimdevices.com/index.php/User:Erland). If my answer
helped you and you like to encourage future presence on this forum
and/or third party plugin/applet development, 'donations are always
appreciated' (http://erland.isaksson.info/donate))
------------------------------------------------------------------------
erland's Profile: http://forums.slimdevices.com/member.php?userid=3124
View this thread: http://forums.slimdevices.com/showthread.php?t=87720
_______________________________________________
beta mailing list
[email protected]
http://lists.slimdevices.com/mailman/listinfo/beta
