mr_hyde;650285 Wrote: 
> Sure, if you prefer several MB of warnings per day, leave it in, or
> better modify the startup scripts or SbS on your own for future
> releases. If you would have read the posts carefully, you would have
> seen that SSOTS modifies the SbS file to generate these warnings. They
> are not there per default and they are just not useful if you want to
> search your logfile for real problems.
> 
> You can always activate the warnings per SbS module in the logging tab.
> They should not be there by default to spam the logfile
That's not my point.
With 7.5.x, the -w flag was already used and didn't fire so many
warnings in the log files.

Some of these warnings are trivial to get rid of:

Code:
--------------------
    "my" variable $playlist_id masks earlier declaration in same scope at 
Slim/Web/Pages/EditPlaylist.pm line 46.
  "my" variable $cacheKey masks earlier declaration in same scope at 
Slim/Control/Queries.pm line 789.
  Scalar value @crumbIndex[-1] better written as $crumbIndex[-1] at 
Slim/Control/XMLBrowser.pm line 397.
--------------------


Other may indicate something is really wrong within the code:

Code:
--------------------
    Use of uninitialized value in string eq at Slim/Web/Cometd.pm line 456.
  Use of uninitialized value in string eq at Slim/Web/Cometd.pm line 574.
  Use of uninitialized value in string eq at Slim/Web/Cometd.pm line 646.
  Use of uninitialized value in string eq at Slim/Web/Cometd.pm line 672.
--------------------

How come there's no client transport method defined?


Code:
--------------------
    Use of uninitialized value $protocol in hash element at 
Slim/Player/ProtocolHandlers.pm line 43.
  Use of uninitialized value $protocol in exists at 
Slim/Player/ProtocolHandlers.pm line 47.
--------------------

How come there's no protocol passed to isValidHandler()?


Code:
--------------------
    Use of uninitialized value $quantity in pattern match (m//) at 
Slim/Control/Queries.pm line 524.
--------------------

$quantity isn't defined during call to albumsQuery, which shouldn't
occur, AFAICT (Slim/Control/Request.pm requires it).
Not sure it's related to the problem, but it's in a code block dealing
with the "No Album" case, and I couldn't help reminding 'JJZolx' case'
(http://forums.slimdevices.com/showthread.php?t=89624).

I hope it's clear I'm not bashing the devs, here.
They've done a great work lately, and got rid of the most serious bugs.

My point is just that one shouldn't ignore such warnings, especially
given there were so few with 7.5.


-- 
sebp

'Last.fm' (http://www.last.fm/user/sebp)
------------------------------------------------------------------------
sebp's Profile: http://forums.slimdevices.com/member.php?userid=11768
View this thread: http://forums.slimdevices.com/showthread.php?t=89619

_______________________________________________
beta mailing list
[email protected]
http://lists.slimdevices.com/mailman/listinfo/beta

Reply via email to