Hey flipflip long time no see :-)
- What's the allowed "nodes" parameter for Slim::Menu::BrowseLibrary()? Slim::Menu::BrowseLibrary::_albums(), _tracks(), _years() etc. all work. _topLevel(), however, doesn't seem to work (UI stalls / loads endlessly). I haven't looked into the code, and it's not very important. But to have all the standard browse modes (by album/artist/track/year/search/..) below each library would be nice.
Good point. Could imagine this might be interesting to some users. Will see what I can do.
- The "name" parameter for Slim::Music::VirtualLibraries->registerLibrary() doesn't seem to support strings.txt constants. Shouldn't it?
It doesn't, and I don't know whether it should. What's the use case?
- How's the scannerCB() function passed to Slim::Music::VirtualLibraries->registerLibrary() supposed to work? From looking at the code in Slim::Music::VirtualLibraries::rebuild() I guess it would not only have to fill in the records in library_track but also populate the helper tables (library_album, library_contributor, etc.). Is that right? If so, shouldn't rebuild() take care of emptying the table before calling scannerCB() and populating the auxiliary tables after calling scannerCB(). This would spare us from maintaining duplicated code in scannerCB().
When I initially thought of the CB function, there were no tables for albums, contributors etc. yet. And I had some use case in mind which would leave all responsibility to the callback indeed.
I'll have to review this, too. Do you have a use for it already? I might just pull it instead...
Or possibly, scannerCB() could just return a list of track ids that should go into the library and then rebuild() could take care of all the database stuff?
That would make sense indeed.
(I may have completely missed the point...)
Nope. You only pointed at some ugly details which got neglected while the code grew :-).
And related to creating a scannerCB().. What's the proper way to decode a tracks.url into a local file system path (using SQL LIKE on it is a bit of a pain, I'd rather regex match it)? But never mind, I'll find out.. :-)
Something like Slim::Music::Info::fileName($url) -- Michael _______________________________________________ beta mailing list [email protected] http://lists.slimdevices.com/mailman/listinfo/beta
