Revision: 16394
          
http://projects.blender.org/plugins/scmsvn/viewcvs.php?view=rev&root=bf-blender&revision=16394
Author:   blendix
Date:     2008-09-06 15:24:42 +0200 (Sat, 06 Sep 2008)

Log Message:
-----------
Revert a commit from 5 years ago that added a glFinish call before swapping on 
Windows. This is really bad for performance and especially showed in the game 
engine. The purpose was to disable FSAA and fix some UI issue on Geforce 2 
graphics cards, hopefully the drivers have been fixed by now? I have no way to 
test this, so we'll see if an issue pops up on those older cards, and a lot of 
code changed since then anyway so it might not even be needed anymore.

Modified Paths:
--------------
    trunk/blender/intern/ghost/intern/GHOST_WindowWin32.cpp

Modified: trunk/blender/intern/ghost/intern/GHOST_WindowWin32.cpp
===================================================================
--- trunk/blender/intern/ghost/intern/GHOST_WindowWin32.cpp     2008-09-06 
12:50:22 UTC (rev 16393)
+++ trunk/blender/intern/ghost/intern/GHOST_WindowWin32.cpp     2008-09-06 
13:24:42 UTC (rev 16394)
@@ -437,7 +437,13 @@
        // adding a glFinish() here is to prevent Geforce in 'full scene 
antialias' mode
        // from antialising the Blender window. Officially a swapbuffers does a 
glFinish
        // itself, so this feels really like a hack... but it won't harm. (ton)
-       glFinish();
+       // 
+       // disabled this because it is a performance killer for the game 
engine, glFinish
+       // forces synchronization with the graphics card and calling it is 
strongly
+       // discouraged for good performance. (brecht)
+       //
+       // glFinish();
+
        return ::SwapBuffers(m_hDC) == TRUE ? GHOST_kSuccess : GHOST_kFailure;
 }
 


_______________________________________________
Bf-blender-cvs mailing list
Bf-blender-cvs@blender.org
http://lists.blender.org/mailman/listinfo/bf-blender-cvs

Reply via email to