[Bf-blender-cvs] SVN commit: /data/svn/bf-blender [20602] trunk/blender/source/blender/ blenkernel/intern/cloth.c: Missed this one before.

[Kent Mein]

Revision: 20602
          
http://projects.blender.org/plugins/scmsvn/viewcvs.php?view=rev&root=bf-blender&revision=20602
Author:   sirdude
Date:     2009-06-03 17:14:09 +0200 (Wed, 03 Jun 2009)

Log Message:
-----------
Missed this one before.  It's another coverity issue:
CID: 477
Checker: REVERSE_INULL (help)
File: base/src/source/blender/blenkernel/intern/cloth.c
Function: cloth_apply_vgroup
Description: Pointer "dm" dereferenced before NULL check

Just like the others it assigned the value twice, removed
the one that was before checking for NULL.

Kent

Modified Paths:
--------------
    trunk/blender/source/blender/blenkernel/intern/cloth.c

Modified: trunk/blender/source/blender/blenkernel/intern/cloth.c
===================================================================
--- trunk/blender/source/blender/blenkernel/intern/cloth.c      2009-06-03 
14:55:41 UTC (rev 20601)
+++ trunk/blender/source/blender/blenkernel/intern/cloth.c      2009-06-03 
15:14:09 UTC (rev 20602)
@@ -786,15 +786,14 @@
        int j = 0;
        MDeformVert *dvert = NULL;
        Cloth *clothObj = NULL;
-       int numverts = dm->getNumVerts ( dm );
+       int numverts;
        float goalfac = 0;
        ClothVertex *verts = NULL;
 
+       if (!clmd || !dm) return;
+
        clothObj = clmd->clothObject;
 
-       if ( !dm )
-               return;
-       
        numverts = dm->getNumVerts ( dm );
 
        verts = clothObj->verts;


_______________________________________________
Bf-blender-cvs mailing list
Bf-blender-cvs@blender.org
http://lists.blender.org/mailman/listinfo/bf-blender-cvs