[Bf-blender-cvs] [e2a401f3441] blender2.8: UI: Name added LightProbe objects after their type.

[Pablo Vazquez]

Commit: e2a401f3441ff5a97b4d51b2bba6ca8eae1dd038
Author: Pablo Vazquez
Date:   Fri Nov 9 02:16:26 2018 +0100
Branches: blender2.8
https://developer.blender.org/rBe2a401f3441ff5a97b4d51b2bba6ca8eae1dd038

UI: Name added LightProbe objects after their type.

Just like Light objects do.

Thanks ThinkingPolygons from DevTalk forums for suggesting this!

See T56950

===================================================================

M       source/blender/editors/object/object_add.c

===================================================================

diff --git a/source/blender/editors/object/object_add.c 
b/source/blender/editors/object/object_add.c
index c0a11f9dece..4f0961978f9 100644
--- a/source/blender/editors/object/object_add.c
+++ b/source/blender/editors/object/object_add.c
@@ -467,6 +467,17 @@ void OBJECT_OT_add(wmOperatorType *ot)
 /********************** Add Probe Operator **********************/
 
 /* for object add operator */
+static const char *get_lightprobe_defname(int type)
+{
+       switch (type) {
+               case LIGHTPROBE_TYPE_GRID: return 
CTX_DATA_(BLT_I18NCONTEXT_ID_LAMP, "IrradianceVolume");
+               case LIGHTPROBE_TYPE_PLANAR: return 
CTX_DATA_(BLT_I18NCONTEXT_ID_LAMP, "ReflectionPlane");
+               case LIGHTPROBE_TYPE_CUBE: return 
CTX_DATA_(BLT_I18NCONTEXT_ID_LAMP, "ReflectionCubemap");
+               default:
+                       return CTX_DATA_(BLT_I18NCONTEXT_ID_LAMP, "LightProbe");
+       }
+}
+
 static int lightprobe_add_exec(bContext *C, wmOperator *op)
 {
        Object *ob;
@@ -483,8 +494,7 @@ static int lightprobe_add_exec(bContext *C, wmOperator *op)
        type = RNA_enum_get(op->ptr, "type");
        radius = RNA_float_get(op->ptr, "radius");
 
-       const char *name = CTX_DATA_(BLT_I18NCONTEXT_ID_OBJECT, "Light Probe");
-       ob = ED_object_add_type(C, OB_LIGHTPROBE, name, loc, rot, false);
+       ob = ED_object_add_type(C, OB_LIGHTPROBE, get_lightprobe_defname(type), 
loc, rot, false);
        BKE_object_obdata_size_init(ob, radius);
 
        probe = (LightProbe *)ob->data;
@@ -506,7 +516,7 @@ static int lightprobe_add_exec(bContext *C, wmOperator *op)
                        probe->attenuation_type = LIGHTPROBE_SHAPE_ELIPSOID;
                        break;
                default:
-                       BLI_assert(!"Lightprobe type not configured.");
+                       BLI_assert(!"LightProbe type not configured.");
                        break;
        }

_______________________________________________
Bf-blender-cvs mailing list
Bf-blender-cvs@blender.org
https://lists.blender.org/mailman/listinfo/bf-blender-cvs