Commit: b25bb2d7ec31ef08d67142ad655d59cd37e1d747
Author: Sybren A. Stüvel
Date: Fri Nov 29 10:37:43 2019 +0100
Branches: master
https://developer.blender.org/rBb25bb2d7ec31ef08d67142ad655d59cd37e1d747
Archive build script: stop when creating archive fails
The `subprocess.call()` function doesn't check the exit status code of the
subprocess. Use `subprocess.check_call()` or `subprocess.run()` instead.
===================================================================
M build_files/package_spec/build_archive.py
===================================================================
diff --git a/build_files/package_spec/build_archive.py
b/build_files/package_spec/build_archive.py
index 754bb8cd402..d8d3c29ea48 100755
--- a/build_files/package_spec/build_archive.py
+++ b/build_files/package_spec/build_archive.py
@@ -61,7 +61,7 @@ try:
sys.stderr.write('Unknown archive extension: ' + extension)
sys.exit(-1)
- subprocess.call(archive_cmd)
+ subprocess.check_call(archive_cmd, env=archive_env)
except Exception as ex:
sys.stderr.write('Failed to create package archive: ' + str(ex) + '\n')
sys.exit(1)
_______________________________________________
Bf-blender-cvs mailing list
Bf-blender-cvs@blender.org
https://lists.blender.org/mailman/listinfo/bf-blender-cvs
