Commit: 9fa6e06287dc49f1fcf2bbfa150c0ff368668fed
Author: Jacques Lucke
Date: Fri Feb 12 12:33:04 2021 +0100
Branches: blender-v2.92-release
https://developer.blender.org/rB9fa6e06287dc49f1fcf2bbfa150c0ff368668fed
Geometry Nodes: remove incorrect assert
It is perfectly valid that an attribute does not exist and cannot be created.
For example, this can happen when a mesh does not contain any vertices.
===================================================================
M source/blender/nodes/geometry/nodes/node_geo_point_separate.cc
===================================================================
diff --git a/source/blender/nodes/geometry/nodes/node_geo_point_separate.cc
b/source/blender/nodes/geometry/nodes/node_geo_point_separate.cc
index 066b2952111..5f9d208a440 100644
--- a/source/blender/nodes/geometry/nodes/node_geo_point_separate.cc
+++ b/source/blender/nodes/geometry/nodes/node_geo_point_separate.cc
@@ -84,19 +84,15 @@ static void move_split_attributes(const GeometryComponent
&in_component,
const CustomDataType data_type =
bke::cpp_type_to_custom_data_type(attribute->cpp_type());
const AttributeDomain domain = attribute->domain();
- /* Don't try to create the attribute on the new component if it already
exists. Built-in
- * attributes will already exist on new components by definition. It
should always be possible
- * to recreate the attribute on the same component type. Also, if one of
the new components
- * has the attribute the other one should have it too, but check
independently to be safe. */
+ /* Don't try to create the attribute on the new component if it already
exists (i.e. has been
+ * initialized by someone else). */
if (!out_component_a.attribute_exists(name)) {
if (!out_component_a.attribute_try_create(name, domain, data_type)) {
- BLI_assert(false);
continue;
}
}
if (!out_component_b.attribute_exists(name)) {
if (!out_component_b.attribute_try_create(name, domain, data_type)) {
- BLI_assert(false);
continue;
}
}
_______________________________________________
Bf-blender-cvs mailing list
[email protected]
https://lists.blender.org/mailman/listinfo/bf-blender-cvs
