Commit: 90c3147e05b31000ad6ca2f9db1d1b0907c7acd6
Author: Hans Goudey
Date: Tue Mar 8 12:31:21 2022 -0600
Branches: master
https://developer.blender.org/rB90c3147e05b31000ad6ca2f9db1d1b0907c7acd6
Cleanup: Correct comment
Normals aren't stored in custom data anymore, nor are they stored in
MVert for comparisons.
===================================================================
M source/blender/blenkernel/intern/mesh.cc
===================================================================
diff --git a/source/blender/blenkernel/intern/mesh.cc
b/source/blender/blenkernel/intern/mesh.cc
index 37564f9334f..824c1ab1b90 100644
--- a/source/blender/blenkernel/intern/mesh.cc
+++ b/source/blender/blenkernel/intern/mesh.cc
@@ -142,11 +142,11 @@ static void mesh_copy_data(Main *bmain, ID *id_dst, const
ID *id_src, const int
mesh_dst->mselect = (MSelect *)MEM_dupallocN(mesh_dst->mselect);
- /* Set normal layers dirty, since they aren't included in CD_MASK_MESH and
are therefore not
- * copied to the destination mesh. Alternatively normal layers could be
copied if they aren't
- * dirty, avoiding recomputation in some cases. However, a copied mesh is
often changed anyway,
- * so that idea is not clearly better. With proper reference counting, all
custom data layers
- * could be copied as the cost would be much lower. */
+ /* Set normal layers dirty. They should be dirty by default on new meshes
anyway, but being
+ * explicit about it is safer. Alternatively normal layers could be copied
if they aren't dirty,
+ * avoiding recomputation in some cases. However, a copied mesh is often
changed anyway, so that
+ * idea is not clearly better. With proper reference counting, all custom
data layers could be
+ * copied as the cost would be much lower. */
BKE_mesh_normals_tag_dirty(mesh_dst);
/* TODO: Do we want to add flag to prevent this? */
@@ -510,7 +510,6 @@ static int customdata_compare(
return MESHCMP_VERTCOMISMATCH;
}
}
- /* I don't care about normals, let's just do coordinates. */
}
break;
}
_______________________________________________
Bf-blender-cvs mailing list
[email protected]
List details, subscription details or unsubscribe:
https://lists.blender.org/mailman/listinfo/bf-blender-cvs
