Revision: 35397
          
http://projects.blender.org/scm/viewvc.php?view=rev&root=bf-blender&revision=35397
Author:   campbellbarton
Date:     2011-03-08 03:14:59 +0000 (Tue, 08 Mar 2011)
Log Message:
-----------
Old IDProperty bug, (from original commit r8916),
found crash while changing operator string size.

Shrinking arrays never worked right.
rather then "newlen * sizeof(...)", it would memcpy "newlen * oldlen * 
sizeof(...)" which always goes over the array bounds.

Revision Links:
--------------
    
http://projects.blender.org/scm/viewvc.php?view=rev&root=bf-blender&revision=8916

Modified Paths:
--------------
    trunk/blender/source/blender/blenkernel/intern/idprop.c

Modified: trunk/blender/source/blender/blenkernel/intern/idprop.c
===================================================================
--- trunk/blender/source/blender/blenkernel/intern/idprop.c     2011-03-08 
02:24:29 UTC (rev 35396)
+++ trunk/blender/source/blender/blenkernel/intern/idprop.c     2011-03-08 
03:14:59 UTC (rev 35397)
@@ -240,7 +240,7 @@
        else {
                /* newlen is smaller*/
                idp_resize_group_array(prop, newlen, newarr);
-               memcpy(newarr, prop->data.pointer, 
newlen*prop->len*idp_size_table[(int)prop->subtype]);
+               memcpy(newarr, prop->data.pointer, 
newlen*idp_size_table[(int)prop->subtype]);
        }
 
        MEM_freeN(prop->data.pointer);

_______________________________________________
Bf-blender-cvs mailing list
[email protected]
http://lists.blender.org/mailman/listinfo/bf-blender-cvs

Reply via email to