Revision: 48259
http://projects.blender.org/scm/viewvc.php?view=rev&root=bf-blender&revision=48259
Author: campbellbarton
Date: 2012-06-25 08:58:50 +0000 (Mon, 25 Jun 2012)
Log Message:
-----------
comment for TODO - rgb_to_bw / rgb_to_grayscale usage.
Modified Paths:
--------------
trunk/blender/source/blender/blenlib/intern/math_color_inline.c
Modified: trunk/blender/source/blender/blenlib/intern/math_color_inline.c
===================================================================
--- trunk/blender/source/blender/blenlib/intern/math_color_inline.c
2012-06-25 08:52:45 UTC (rev 48258)
+++ trunk/blender/source/blender/blenlib/intern/math_color_inline.c
2012-06-25 08:58:50 UTC (rev 48259)
@@ -222,8 +222,16 @@
r_col[2] = ((pack) >> 16) & 0xFF;
}
-/* XXX - investigate when/why rgb_to_bw & rgb_to_grayscale are different,
- * and why we use both! whats the purpose of this? */
+/* TODO:
+ *
+ * regarding #rgb_to_bw vs #rgb_to_grayscale,
+ * it seems nobody knows why we have both functions which convert color to
greys
+ * but with different influences, this is quite stupid, and should be resolved
+ * by someone who knows this stuff: see this thread
+ * http://lists.blender.org/pipermail/bf-committers/2012-June/037180.html
+ *
+ * Only conclusion is that rgb_to_grayscale is used more for compositing.
+ */
MINLINE float rgb_to_bw(const float rgb[3])
{
return 0.35f * rgb[0] + 0.45f * rgb[1] + 0.2f * rgb[2];
_______________________________________________
Bf-blender-cvs mailing list
[email protected]
http://lists.blender.org/mailman/listinfo/bf-blender-cvs
