Revision: 48420
          
http://projects.blender.org/scm/viewvc.php?view=rev&root=bf-blender&revision=48420
Author:   campbellbarton
Date:     2012-06-29 23:09:19 +0000 (Fri, 29 Jun 2012)
Log Message:
-----------
mark modifier operators that only work in the UI as internal, otherwise this 
causes some confusion when they do nothing when accessed from the spacebar 
search menu.

Modified Paths:
--------------
    trunk/blender/source/blender/editors/object/object_modifier.c

Modified: trunk/blender/source/blender/editors/object/object_modifier.c
===================================================================
--- trunk/blender/source/blender/editors/object/object_modifier.c       
2012-06-29 23:02:00 UTC (rev 48419)
+++ trunk/blender/source/blender/editors/object/object_modifier.c       
2012-06-29 23:09:19 UTC (rev 48420)
@@ -844,19 +844,21 @@
 
 static int edit_modifier_invoke_properties(bContext *C, wmOperator *op)
 {
-       PointerRNA ptr = CTX_data_pointer_get_type(C, "modifier", 
&RNA_Modifier);
        ModifierData *md;
        
-       if (RNA_struct_property_is_set(op->ptr, "modifier"))
-               return 1;
-       
-       if (ptr.data) {
-               md = ptr.data;
-               RNA_string_set(op->ptr, "modifier", md->name);
-               return 1;
+       if (RNA_struct_property_is_set(op->ptr, "modifier")) {
+               return TRUE;
        }
-       
-       return 0;
+       else {
+               PointerRNA ptr = CTX_data_pointer_get_type(C, "modifier", 
&RNA_Modifier);
+               if (ptr.data) {
+                       md = ptr.data;
+                       RNA_string_set(op->ptr, "modifier", md->name);
+                       return TRUE;
+               }
+       }
+
+       return FALSE;
 }
 
 static ModifierData *edit_modifier_property_get(wmOperator *op, Object *ob, 
int type)
@@ -916,7 +918,7 @@
        ot->poll = edit_modifier_poll;
        
        /* flags */
-       ot->flag = OPTYPE_REGISTER | OPTYPE_UNDO;
+       ot->flag = OPTYPE_REGISTER | OPTYPE_UNDO | OPTYPE_INTERNAL;
        edit_modifier_properties(ot);
 }
 
@@ -955,7 +957,7 @@
        ot->poll = edit_modifier_poll;
        
        /* flags */
-       ot->flag = OPTYPE_REGISTER | OPTYPE_UNDO;
+       ot->flag = OPTYPE_REGISTER | OPTYPE_UNDO | OPTYPE_INTERNAL;
        edit_modifier_properties(ot);
 }
 
@@ -994,7 +996,7 @@
        ot->poll = edit_modifier_poll;
        
        /* flags */
-       ot->flag = OPTYPE_REGISTER | OPTYPE_UNDO;
+       ot->flag = OPTYPE_REGISTER | OPTYPE_UNDO | OPTYPE_INTERNAL;
        edit_modifier_properties(ot);
 }
 
@@ -1042,7 +1044,7 @@
        ot->poll = edit_modifier_poll;
        
        /* flags */
-       ot->flag = OPTYPE_REGISTER | OPTYPE_UNDO;
+       ot->flag = OPTYPE_REGISTER | OPTYPE_UNDO | OPTYPE_INTERNAL;
        
        RNA_def_enum(ot->srna, "apply_as", modifier_apply_as_items, 
MODIFIER_APPLY_DATA, "Apply as", "How to apply the modifier to the geometry");
        edit_modifier_properties(ot);
@@ -1085,7 +1087,7 @@
        ot->poll = edit_modifier_poll;
        
        /* flags */
-       ot->flag = OPTYPE_REGISTER | OPTYPE_UNDO;
+       ot->flag = OPTYPE_REGISTER | OPTYPE_UNDO | OPTYPE_INTERNAL;
        edit_modifier_properties(ot);
 }
 
@@ -1124,7 +1126,7 @@
        ot->poll = edit_modifier_poll;
        
        /* flags */
-       ot->flag = OPTYPE_REGISTER | OPTYPE_UNDO;
+       ot->flag = OPTYPE_REGISTER | OPTYPE_UNDO | OPTYPE_INTERNAL;
        edit_modifier_properties(ot);
 }
 
@@ -1173,7 +1175,7 @@
        ot->exec = multires_higher_levels_delete_exec;
        
        /* flags */
-       ot->flag = OPTYPE_REGISTER | OPTYPE_UNDO;
+       ot->flag = OPTYPE_REGISTER | OPTYPE_UNDO | OPTYPE_INTERNAL;
        edit_modifier_properties(ot);
 }
 
@@ -1218,7 +1220,7 @@
        ot->exec = multires_subdivide_exec;
        
        /* flags */
-       ot->flag = OPTYPE_REGISTER | OPTYPE_UNDO;
+       ot->flag = OPTYPE_REGISTER | OPTYPE_UNDO | OPTYPE_INTERNAL;
        edit_modifier_properties(ot);
 }
 
@@ -1282,7 +1284,7 @@
        ot->exec = multires_reshape_exec;
        
        /* flags */
-       ot->flag = OPTYPE_REGISTER | OPTYPE_UNDO;
+       ot->flag = OPTYPE_REGISTER | OPTYPE_UNDO | OPTYPE_INTERNAL;
        edit_modifier_properties(ot);
 }
 
@@ -1357,7 +1359,7 @@
        ot->poll = multires_poll;
        
        /* flags */
-       ot->flag = OPTYPE_REGISTER | OPTYPE_UNDO;
+       ot->flag = OPTYPE_REGISTER | OPTYPE_UNDO | OPTYPE_INTERNAL;
 
        WM_operator_properties_filesel(ot, FOLDERFILE | BTXFILE, FILE_SPECIAL, 
FILE_SAVE, WM_FILESEL_FILEPATH | WM_FILESEL_RELPATH, FILE_DEFAULTDISPLAY);
        edit_modifier_properties(ot);
@@ -1429,7 +1431,7 @@
        ot->exec = multires_base_apply_exec;
        
        /* flags */
-       ot->flag = OPTYPE_REGISTER | OPTYPE_UNDO;
+       ot->flag = OPTYPE_REGISTER | OPTYPE_UNDO | OPTYPE_INTERNAL;
        edit_modifier_properties(ot);
 }
 
@@ -1844,7 +1846,7 @@
        ot->exec = skin_armature_create_exec;
        
        /* flags */
-       ot->flag = OPTYPE_REGISTER | OPTYPE_UNDO;
+       ot->flag = OPTYPE_REGISTER | OPTYPE_UNDO | OPTYPE_INTERNAL;
        edit_modifier_properties(ot);
 }
 
@@ -1939,7 +1941,7 @@
        ot->exec = meshdeform_bind_exec;
        
        /* flags */
-       ot->flag = OPTYPE_REGISTER | OPTYPE_UNDO;
+       ot->flag = OPTYPE_REGISTER | OPTYPE_UNDO | OPTYPE_INTERNAL;
        edit_modifier_properties(ot);
 }
 
@@ -1986,7 +1988,7 @@
        ot->exec = explode_refresh_exec;
        
        /* flags */
-       ot->flag = OPTYPE_REGISTER | OPTYPE_UNDO;
+       ot->flag = OPTYPE_REGISTER | OPTYPE_UNDO | OPTYPE_INTERNAL;
        edit_modifier_properties(ot);
 }
 
@@ -2201,7 +2203,7 @@
        ot->exec = ocean_bake_exec;
        
        /* flags */
-       ot->flag = OPTYPE_REGISTER | OPTYPE_UNDO;
+       ot->flag = OPTYPE_REGISTER | OPTYPE_UNDO | OPTYPE_INTERNAL;
        edit_modifier_properties(ot);
        
        RNA_def_boolean(ot->srna, "free", FALSE, "Free", "Free the bake, rather 
than generating it");

_______________________________________________
Bf-blender-cvs mailing list
[email protected]
http://lists.blender.org/mailman/listinfo/bf-blender-cvs

Reply via email to