[Bf-blender-cvs] SVN commit: /data/svn/bf-blender [52421] trunk/blender/source/blender/ editors: Fix #33241: can' t exit edit mode when object gets hidden via animation.

[Brecht Van Lommel]

Revision: 52421
          
http://projects.blender.org/scm/viewvc.php?view=rev&root=bf-blender&revision=52421
Author:   blendix
Date:     2012-11-21 03:33:34 +0000 (Wed, 21 Nov 2012)
Log Message:
-----------
Fix #33241: can't exit edit mode when object gets hidden via animation.

Modified Paths:
--------------
    trunk/blender/source/blender/editors/object/object_edit.c
    trunk/blender/source/blender/editors/screen/screen_ops.c
    trunk/blender/source/blender/editors/space_view3d/space_view3d.c

Modified: trunk/blender/source/blender/editors/object/object_edit.c
===================================================================
--- trunk/blender/source/blender/editors/object/object_edit.c   2012-11-21 
02:28:36 UTC (rev 52420)
+++ trunk/blender/source/blender/editors/object/object_edit.c   2012-11-21 
03:33:34 UTC (rev 52421)
@@ -550,7 +550,8 @@
        if (ELEM(NULL, ob, ob->data) || ((ID *)ob->data)->lib)
                return 0;
 
-       if (ob->restrictflag & OB_RESTRICT_VIEW)
+       /* if hidden but in edit mode, we still display */
+       if ((ob->restrictflag & OB_RESTRICT_VIEW) && !(ob->mode & OB_MODE_EDIT))
                return 0;
 
        return (ob->type == OB_MESH || ob->type == OB_ARMATURE ||

Modified: trunk/blender/source/blender/editors/screen/screen_ops.c
===================================================================
--- trunk/blender/source/blender/editors/screen/screen_ops.c    2012-11-21 
02:28:36 UTC (rev 52420)
+++ trunk/blender/source/blender/editors/screen/screen_ops.c    2012-11-21 
03:33:34 UTC (rev 52421)
@@ -293,29 +293,35 @@
        return ed_spacetype_test(C, SPACE_CONSOLE);
 }
 
+static int ed_object_hidden(Object *ob)
+{
+       /* if hidden but in edit mode, we still display, can happen with 
animation */
+       return ((ob->restrictflag & OB_RESTRICT_VIEW) && !(ob->mode & 
OB_MODE_EDIT));
+}
+
 int ED_operator_object_active(bContext *C)
 {
        Object *ob = ED_object_active_context(C);
-       return ((ob != NULL) && !(ob->restrictflag & OB_RESTRICT_VIEW));
+       return ((ob != NULL) && !ed_object_hidden(ob));
 }
 
 int ED_operator_object_active_editable(bContext *C)
 {
        Object *ob = ED_object_active_context(C);
-       return ((ob != NULL) && !(ob->id.lib) && !(ob->restrictflag & 
OB_RESTRICT_VIEW));
+       return ((ob != NULL) && !(ob->id.lib) && !ed_object_hidden(ob));
 }
 
 int ED_operator_object_active_editable_mesh(bContext *C)
 {
        Object *ob = ED_object_active_context(C);
-       return ((ob != NULL) && !(ob->id.lib) && !(ob->restrictflag & 
OB_RESTRICT_VIEW) &&
+       return ((ob != NULL) && !(ob->id.lib) && !ed_object_hidden(ob) &&
                (ob->type == OB_MESH) && !(((ID *)ob->data)->lib));
 }
 
 int ED_operator_object_active_editable_font(bContext *C)
 {
        Object *ob = ED_object_active_context(C);
-       return ((ob != NULL) && !(ob->id.lib) && !(ob->restrictflag & 
OB_RESTRICT_VIEW) &&
+       return ((ob != NULL) && !(ob->id.lib) && !ed_object_hidden(ob) &&
                (ob->type == OB_FONT));
 }
 

Modified: trunk/blender/source/blender/editors/space_view3d/space_view3d.c
===================================================================
--- trunk/blender/source/blender/editors/space_view3d/space_view3d.c    
2012-11-21 02:28:36 UTC (rev 52420)
+++ trunk/blender/source/blender/editors/space_view3d/space_view3d.c    
2012-11-21 03:33:34 UTC (rev 52421)
@@ -1119,16 +1119,21 @@
                return 1;
        }
        else if (CTX_data_equals(member, "active_base")) {
-               if (scene->basact && (scene->basact->lay & lay))
-                       if ((scene->basact->object->restrictflag & 
OB_RESTRICT_VIEW) == 0)
+               if (scene->basact && (scene->basact->lay & lay)) {
+                       Object *ob = scene->basact->object;
+                       /* if hidden but in edit mode, we still display, can 
happen with animation */
+                       if ((ob->restrictflag & OB_RESTRICT_VIEW) == 0 || 
(ob->mode & OB_MODE_EDIT))
                                CTX_data_pointer_set(result, &scene->id, 
&RNA_ObjectBase, scene->basact);
+               }
                
                return 1;
        }
        else if (CTX_data_equals(member, "active_object")) {
-               if (scene->basact && (scene->basact->lay & lay))
-                       if ((scene->basact->object->restrictflag & 
OB_RESTRICT_VIEW) == 0)
+               if (scene->basact && (scene->basact->lay & lay)) {
+                       Object *ob = scene->basact->object;
+                       if ((ob->restrictflag & OB_RESTRICT_VIEW) == 0 || 
(ob->mode & OB_MODE_EDIT))
                                CTX_data_id_pointer_set(result, 
&scene->basact->object->id);
+               }
                
                return 1;
        }

_______________________________________________
Bf-blender-cvs mailing list
Bf-blender-cvs@blender.org
http://lists.blender.org/mailman/listinfo/bf-blender-cvs