[Bf-blender-cvs] SVN commit: /data/svn/bf-blender [57008] trunk/blender/source/blender/ modifiers/intern/MOD_solidify.c: fix for out of bounds memory access in solidify ( harmless with guardedalloc padding but bad practice)

[Campbell Barton]

Revision: 57008
          
http://projects.blender.org/scm/viewvc.php?view=rev&root=bf-blender&revision=57008
Author:   campbellbarton
Date:     2013-05-25 00:22:04 +0000 (Sat, 25 May 2013)
Log Message:
-----------
fix for out of bounds memory access in solidify (harmless with guardedalloc 
padding but bad practice)

Modified Paths:
--------------
    trunk/blender/source/blender/modifiers/intern/MOD_solidify.c

Modified: trunk/blender/source/blender/modifiers/intern/MOD_solidify.c
===================================================================
--- trunk/blender/source/blender/modifiers/intern/MOD_solidify.c        
2013-05-24 21:27:30 UTC (rev 57007)
+++ trunk/blender/source/blender/modifiers/intern/MOD_solidify.c        
2013-05-25 00:22:04 UTC (rev 57008)
@@ -112,10 +112,11 @@
 
                        ml = mloop + mp->loopstart;
 
-                       for (j = 0, ml_v1 = ml->v, ml_v2 = ml[mp->totloop - 
1].v;
+                       for (j = 0, ml_v2 = ml[mp->totloop - 1].v;
                             j < mp->totloop;
-                            j++, ml++, ml_v2 = ml_v1, ml_v1 = ml->v)
+                            j++, ml++, ml_v2 = ml_v1)
                        {
+                               ml_v1 = ml->v;
                                /* --- add edge ref to face --- */
                                edge_ref = (EdgeFaceRef 
*)BLI_edgehash_lookup(edge_hash, ml_v1, ml_v2);
                                if (!edge_ref) {

_______________________________________________
Bf-blender-cvs mailing list
Bf-blender-cvs@blender.org
http://lists.blender.org/mailman/listinfo/bf-blender-cvs