Commit: 0cb1c2cdeebd62d15c29d57b20ace99377e22c8f
Author: Bastien Montagne
Date:   Wed Nov 19 20:48:35 2014 +0100
Branches: master
https://developer.blender.org/rB0cb1c2cdeebd62d15c29d57b20ace99377e22c8f

Cleanup: #define -> enums.

===================================================================

M       source/blender/makesdna/DNA_ID.h
M       source/blender/makesdna/DNA_curve_types.h
M       source/blender/makesdna/DNA_dynamicpaint_types.h
M       source/blender/makesdna/DNA_freestyle_types.h

===================================================================

diff --git a/source/blender/makesdna/DNA_ID.h b/source/blender/makesdna/DNA_ID.h
index 33d1445..6454370 100644
--- a/source/blender/makesdna/DNA_ID.h
+++ b/source/blender/makesdna/DNA_ID.h
@@ -44,54 +44,65 @@ struct FileData;
 struct ID;
 struct PackedFile;
 struct GPUTexture;
-       
+
 typedef struct IDPropertyData {
        void *pointer;
        ListBase group;
-       int val, val2; /*note, we actually fit a double into these two ints*/
+       int val, val2;  /* note, we actually fit a double into these two ints */
 } IDPropertyData;
 
 typedef struct IDProperty {
        struct IDProperty *next, *prev;
        char type, subtype;
        short flag;
-       char name[64];  /* MAX_IDPROP_NAME */
-       int saved; /* saved is used to indicate if this struct has been saved 
yet.
-                   * seemed like a good idea as a pad var was needed anyway 
:)*/
-       IDPropertyData data;    /* note, alignment for 64 bits */
-       int len; /* array length, also (this is important!) string length + 1.
-                 * the idea is to be able to reuse array realloc functions on 
strings.*/
+       char name[64];  /* MAX_IDPROP_NAME */
+
+       /* saved is used to indicate if this struct has been saved yet.
+        * seemed like a good idea as a pad var was needed anyway :) */
+       int saved;
+       IDPropertyData data;  /* note, alignment for 64 bits */
+
+       /* array length, also (this is important!) string length + 1.
+        * the idea is to be able to reuse array realloc functions on strings.*/
+       int len;
+
+       /* Strings and arrays are both buffered, though the buffer isn't saved. 
*/
        /* totallen is total length of allocated array/string, including a 
buffer.
-        * Note that the buffering is mild; the code comes from python's list 
implementation.*/
-       int totallen; /*strings and arrays are both buffered, though the buffer 
isn't saved.*/
+        * Note that the buffering is mild; the code comes from python's list 
implementation. */
+       int totallen;
 } IDProperty;
 
-#define MAX_IDPROP_NAME        64
-#define DEFAULT_ALLOC_FOR_NULL_STRINGS 64
+#define MAX_IDPROP_NAME 64
+#define DEFAULT_ALLOC_FOR_NULL_STRINGS  64
 
 /*->type*/
-#define IDP_STRING             0
-#define IDP_INT                        1
-#define IDP_FLOAT              2
-#define IDP_ARRAY              5
-#define IDP_GROUP              6
-/* the ID link property type hasn't been implemented yet, this will require
- * some cleanup of blenkernel, most likely.*/
-#define IDP_ID                 7
-#define IDP_DOUBLE             8
-#define IDP_IDPARRAY   9
-#define IDP_NUMTYPES   10
+enum {
+       IDP_STRING           = 0,
+       IDP_INT              = 1,
+       IDP_FLOAT            = 2,
+       IDP_ARRAY            = 5,
+       IDP_GROUP            = 6,
+       /* the ID link property type hasn't been implemented yet, this will 
require
+        * some cleanup of blenkernel, most likely. */
+       IDP_ID               = 7,
+       IDP_DOUBLE           = 8,
+       IDP_IDPARRAY         = 9,
+       IDP_NUMTYPES         = 10,
+};
 
 /*->subtype */
 
 /* IDP_STRING */
-#define IDP_STRING_SUB_UTF8  0 /* default */
-#define IDP_STRING_SUB_BYTE  1 /* arbitrary byte array, _not_ null terminated 
*/
-/*->flag*/
-#define IDP_FLAG_GHOST (1<<7)  /* this means the property is set but RNA will 
return
-                                * false when checking 'RNA_property_is_set',
-                                * currently this is a runtime flag */
+enum {
+       IDP_STRING_SUB_UTF8  = 0,  /* default */
+       IDP_STRING_SUB_BYTE  = 1,  /* arbitrary byte array, _not_ null 
terminated */
+};
 
+/*->flag*/
+enum {
+       IDP_FLAG_GHOST       = 1 << 7,  /* this means the property is set but 
RNA will return false when checking
+                                        * 'RNA_property_is_set', currently 
this is a runtime flag */
+};
 
 /* add any future new id property types here.*/
 
@@ -102,7 +113,7 @@ typedef struct IDProperty {
  * */
 
 /* 2 characters for ID code and 64 for actual name */
-#define MAX_ID_NAME    66
+#define MAX_ID_NAME  66
 
 /* There's a nasty circular dependency here.... 'void *' to the rescue! I
  * really wonder why this is needed. */
@@ -129,14 +140,14 @@ typedef struct Library {
        ID id;
        ID *idblock;
        struct FileData *filedata;
-       char name[1024];                /* path name used for reading, can be 
relative and edited in the outliner */
-       char filepath[1024];    /* absolute filepath, this is only for 
convenience,
-                                                        * 'name' is the real 
path used on file read but in
-                                                        * some cases its 
useful to access the absolute one,
-                                                        * This is set on file 
read.
-                                                        * Use 
BKE_library_filepath_set() rather than
-                                                        * setting 'name' 
directly and it will be kept in
-                                                        * sync - campbell */
+       char name[1024];  /* path name used for reading, can be relative and 
edited in the outliner */
+
+       /* absolute filepath, this is only for convenience, 'name' is the real 
path used on file read but in
+        * some cases its useful to access the absolute one.
+        * This is set on file read.
+        * Use BKE_library_filepath_set() rather than setting 'name' directly 
and it will be kept in sync - campbell */
+       char filepath[1024];
+
        struct Library *parent; /* set for indirectly linked libs, used in the 
outliner and while reading */
        
        struct PackedFile *packedfile;
@@ -239,26 +250,28 @@ typedef struct PreviewImage {
 #define ID_NEW_US(a)   if (      (a)->id.newid)       { (a) = (void 
*)(a)->id.newid;       (a)->id.us++; }
 #define ID_NEW_US2(a)  if (((ID *)a)->newid)          { (a) = ((ID  
*)a)->newid;     ((ID *)a)->us++;    }
 
-/* id->flag: set frist 8 bits always at zero while reading */
-#define LIB_LOCAL              0
-#define LIB_EXTERN             1
-#define LIB_INDIRECT   2
-#define LIB_NEED_EXPAND        8
-#define LIB_TESTEXT            (LIB_NEED_EXPAND | LIB_EXTERN)
-#define LIB_TESTIND            (LIB_NEED_EXPAND | LIB_INDIRECT)
-#define LIB_READ               16
-#define LIB_NEED_LINK  32
-
-#define LIB_NEW                        256
-#define LIB_FAKEUSER   512
-/* free test flag */
-#define LIB_DOIT               1024
-/* tag existing data before linking so we know what is new */
-#define LIB_PRE_EXISTING       2048
-/* runtime */
-#define LIB_ID_RECALC          4096
-#define LIB_ID_RECALC_DATA     8192
-#define LIB_ANIM_NO_RECALC 16384
+/* id->flag: set first 8 bits always at zero while reading */
+enum {
+       LIB_LOCAL           = 0,
+       LIB_EXTERN          = 1 << 0,
+       LIB_INDIRECT        = 1 << 1,
+       LIB_NEED_EXPAND     = 1 << 3,
+       LIB_TESTEXT         = (LIB_NEED_EXPAND | LIB_EXTERN),
+       LIB_TESTIND         = (LIB_NEED_EXPAND | LIB_INDIRECT),
+       LIB_READ            = 1 << 4,
+       LIB_NEED_LINK       = 1 << 5,
+
+       LIB_NEW             = 1 << 8,
+       LIB_FAKEUSER        = 1 << 9,
+       /* free test flag */
+       LIB_DOIT            = 1 << 10,
+       /* tag existing data before linking so we know what is new */
+       LIB_PRE_EXISTING    = 1 << 11,
+       /* runtime */
+       LIB_ID_RECALC       = 1 << 12,
+       LIB_ID_RECALC_DATA  = 1 << 13,
+       LIB_ANIM_NO_RECALC  = 1 << 14,
+};
 
 #ifdef __cplusplus
 }
diff --git a/source/blender/makesdna/DNA_curve_types.h 
b/source/blender/makesdna/DNA_curve_types.h
index 87496fb..288743d 100644
--- a/source/blender/makesdna/DNA_curve_types.h
+++ b/source/blender/makesdna/DNA_curve_types.h
@@ -270,86 +270,101 @@ typedef struct Curve {
 
 /* **************** CURVE ********************* */
 
-/* texflag */
-#define CU_AUTOSPACE   1
-
-/* drawflag */
-#define CU_HIDE_HANDLES        (1 << 0)
-#define CU_HIDE_NORMALS        (1 << 1)
-
-/* flag */
-#define CU_3D                  1
-#define CU_FRONT               2
-#define CU_BACK                        4
-#define CU_PATH                        8
-#define CU_FOLLOW              16
-#define CU_UV_ORCO             32
-#define CU_DEFORM_BOUNDS_OFF 64 
-#define CU_STRETCH             128
-/* #define CU_OFFS_PATHDIST    256 */ /* DEPRECATED */
-#define CU_FAST                        512 /* Font: no filling inside editmode 
*/
-/* #define CU_RETOPO               1024 */ /* DEPRECATED */
-#define CU_DS_EXPAND   2048
-#define CU_PATH_RADIUS 4096 /* make use of the path radius if this is enabled 
(default for new curves) */
-#define CU_DEFORM_FILL 8192 /* fill 2d curve after deformation */
-#define CU_FILL_CAPS   16384 /* fill bevel caps */
-#define CU_MAP_TAPER   32768 /* map taper object to beveled area */
-
-/* twist mode */
-#define CU_TWIST_Z_UP                  0
-// #define CU_TWIST_Y_UP                       1 // not used yet
-// #define CU_TWIST_X_UP                       2
-#define CU_TWIST_MINIMUM               3
-#define CU_TWIST_TANGENT               4
-
-/* bevel factor mapping */
+/* Curve.texflag */
 enum {
-       CU_BEVFAC_MAP_RESOLU = 0,
+       CU_AUTOSPACE          = 1,
+};
+
+/* Curve.drawflag */
+enum {
+       CU_HIDE_HANDLES       = 1 << 0,
+       CU_HIDE_NORMALS       = 1 << 1,
+};
+
+/* Curve.flag */
+enum {
+       CU_3D                 = 1 << 0,
+       CU_FRONT              = 1 << 1,
+       CU_BACK               = 1 << 2,
+       CU_PATH               = 1 << 3,
+       CU_FOLLOW             = 1 << 4,
+       CU_UV_ORCO            = 1 << 5,
+       CU_DEFORM_BOUNDS_OFF  = 1 << 6,
+       CU_STRETCH            = 1 << 7,
+       /* CU_OFFS_PATHDIST   = 1 << 8, */  /* DEPRECATED */
+       CU_FAST               = 1 << 9,  /* Font: no filling inside editmode */
+       /* CU_RETOPO          = 1 << 10, */  /* DEPRECATED */
+       CU_DS_EXPAND          = 1 << 11,
+       CU_PATH_RADIUS        = 1 << 12,  /* make use of the path radius if 
this is enabled (default for new curves) */
+       CU_DEFORM_FILL        = 1 << 13,  /* fill 2d curve after deformation */
+       CU_FILL_CAPS          = 1 << 14,  /* fill bevel caps */
+       CU_MAP_TAPER          = 1 << 15,  /* map taper object to beveled area */
+};
+
+/* Curve.twist_mode */
+enum {
+       CU_TWIST_Z_UP         = 0,
+       /* CU_TWIST_Y_UP      = 1, */  /* not used yet */
+       /* CU_TWIST_X_UP      = 2, */
+       CU_TWIST_MINIMUM      = 3,
+       CU_TWIST_TANGENT      = 4,
+};
+
+/* Curve.bevfac1_mapping, Curve.bevfac2_mapping, bevel factor mapping */
+enum {
+       CU_BEVFAC_MAP_RESOLU  = 0,
        CU_BEVFAC_MAP_SEGMENT = 1,
-       CU_BEVFAC_MAP_SPLINE = 2
+       CU_BEVFAC_MAP_SPLINE  = 2,
+};
+
+/* Curve.spacemode */
+enum {
+       CU_LEFT               = 0,
+       CU_MIDDLE             = 1,
+       CU_RIGHT              = 2,
+       CU_JUSTIFY            = 3,
+       CU_FLUSH              = 4,
 };
 
-/* spacemode */
-#define CU_LEFT                        0
-#define CU_MIDDLE              1
-#define CU_RIGHT               2
-#define CU_JUSTIFY             3
-#define CU_FLUSH               4
-
-/* flag (nurb) */
-#define CU_SMOOTH              1
-#define CU_2D                  8 /* moved from type since 2.4x */
-
-/* type (nurb) */
-#define CU_POLY                        0
-#define CU_BEZIER              1
-#define CU_BSPLINE             2
-#define CU_CARDINAL            3
-#define CU_NURBS               4
-#define CU_TYPE                        
(CU_POLY|CU_BEZIER|CU_BSPLINE|CU_CARDINAL|CU_NURBS)
-
-               /* only for adding */
-#define CU_PRIMITIVE   0xF00
-
-               /* 2 or 4 points */
-#define CU_PRIM_CURVE  0x100
-               /* 8 points circle */
-#define CU_PRIM_CIRCLE 0x200
-               /* 4x4 patch Nurb */
-#define CU_PRI

@@ Diff output truncated at 10240 characters. @@

_______________________________________________
Bf-blender-cvs mailing list
[email protected]
http://lists.blender.org/mailman/listinfo/bf-blender-cvs

Reply via email to