[Bf-blender-cvs] [5c69345] master: Fix T47138: Page Down key pages up, instead of down, in Outliner.

[Bastien Montagne]

Commit: 5c69345edc0819f5b518ab06438cc72d4dfa86ca
Author: Bastien Montagne
Date:   Fri Jan 8 09:55:39 2016 +0100
Branches: master
https://developer.blender.org/rB5c69345edc0819f5b518ab06438cc72d4dfa86ca

Fix T47138: Page Down key pages up, instead of down, in Outliner.

Usual operator properties 'saving' after first execution... Double fix here, 
since being
explicit in keymap is good practice too.

===================================================================

M       source/blender/editors/space_outliner/outliner_edit.c
M       source/blender/editors/space_outliner/outliner_ops.c

===================================================================

diff --git a/source/blender/editors/space_outliner/outliner_edit.c 
b/source/blender/editors/space_outliner/outliner_edit.c
index 8f322af..222fe27 100644
--- a/source/blender/editors/space_outliner/outliner_edit.c
+++ b/source/blender/editors/space_outliner/outliner_edit.c
@@ -810,6 +810,8 @@ static int outliner_scroll_page_exec(bContext *C, 
wmOperator *op)
 
 void OUTLINER_OT_scroll_page(wmOperatorType *ot)
 {
+       PropertyRNA *prop;
+
        /* identifiers */
        ot->name = "Scroll Page";
        ot->idname = "OUTLINER_OT_scroll_page";
@@ -820,7 +822,8 @@ void OUTLINER_OT_scroll_page(wmOperatorType *ot)
        ot->poll = ED_operator_outliner_active;
        
        /* properties */
-       RNA_def_boolean(ot->srna, "up", 0, "Up", "Scroll up one page");
+       prop = RNA_def_boolean(ot->srna, "up", 0, "Up", "Scroll up one page");
+       RNA_def_property_flag(prop, PROP_SKIP_SAVE);
 }
 
 /* Search ------------------------------------------------------- */
diff --git a/source/blender/editors/space_outliner/outliner_ops.c 
b/source/blender/editors/space_outliner/outliner_ops.c
index 9710c3f..720cfe1 100644
--- a/source/blender/editors/space_outliner/outliner_ops.c
+++ b/source/blender/editors/space_outliner/outliner_ops.c
@@ -126,7 +126,8 @@ void outliner_keymap(wmKeyConfig *keyconf)
        WM_keymap_add_item(keymap, "OUTLINER_OT_show_active", PERIODKEY, 
KM_PRESS, 0, 0);
        WM_keymap_add_item(keymap, "OUTLINER_OT_show_active", PADPERIOD, 
KM_PRESS, 0, 0);
        
-       WM_keymap_add_item(keymap, "OUTLINER_OT_scroll_page", PAGEDOWNKEY, 
KM_PRESS, 0, 0);
+       kmi = WM_keymap_add_item(keymap, "OUTLINER_OT_scroll_page", 
PAGEDOWNKEY, KM_PRESS, 0, 0);
+       RNA_boolean_set(kmi->ptr, "up", false);
        kmi = WM_keymap_add_item(keymap, "OUTLINER_OT_scroll_page", PAGEUPKEY, 
KM_PRESS, 0, 0);
        RNA_boolean_set(kmi->ptr, "up", true);

_______________________________________________
Bf-blender-cvs mailing list
Bf-blender-cvs@blender.org
http://lists.blender.org/mailman/listinfo/bf-blender-cvs