[Bf-blender-cvs] [8dec4a0] master: Fix for string buffer overflow in DepsNode identifiers.

[Lukas Tönne]

Commit: 8dec4a0e7935f4dde9d64a370b860ab0a1cf582e
Author: Lukas Tönne
Date:   Tue Jun 21 12:51:18 2016 +0200
Branches: master
https://developer.blender.org/rB8dec4a0e7935f4dde9d64a370b860ab0a1cf582e

Fix for string buffer overflow in DepsNode identifiers.

Layer flags can go up to 2^n-1 for n layers, requiring *at least* 9 chars + 1 
terminator for 20 layers.

===================================================================

M       source/blender/depsgraph/intern/nodes/deg_node_component.cc

===================================================================

diff --git a/source/blender/depsgraph/intern/nodes/deg_node_component.cc 
b/source/blender/depsgraph/intern/nodes/deg_node_component.cc
index f5f45dd..6ac45c9 100644
--- a/source/blender/depsgraph/intern/nodes/deg_node_component.cc
+++ b/source/blender/depsgraph/intern/nodes/deg_node_component.cc
@@ -116,10 +116,10 @@ string ComponentDepsNode::identifier() const
 {
        string &idname = this->owner->name;
 
-       char typebuf[7];
+       char typebuf[16];
        sprintf(typebuf, "(%d)", type);
 
-       char layers[7];
+       char layers[16];
        sprintf(layers, "%d", this->layers);
 
        return string(typebuf) + name + " : " + idname + " (Layers: " + layers 
+ ")";

_______________________________________________
Bf-blender-cvs mailing list
Bf-blender-cvs@blender.org
https://lists.blender.org/mailman/listinfo/bf-blender-cvs