Commit: 3a5eff95c59fdf1f2817e5e3ffe7b7f3609d031a
Author: Julian Eisel
Date:   Thu Jul 14 13:58:40 2016 +0200
Branches: master
https://developer.blender.org/rB3a5eff95c59fdf1f2817e5e3ffe7b7f3609d031a

Cleanup: Use BKE_scene_base_add for creating bases

And use __func__ macro.

===================================================================

M       source/blender/blenkernel/intern/scene.c
M       source/blender/editors/space_outliner/outliner_tools.c

===================================================================

diff --git a/source/blender/blenkernel/intern/scene.c 
b/source/blender/blenkernel/intern/scene.c
index 858b6bd..11b60e1 100644
--- a/source/blender/blenkernel/intern/scene.c
+++ b/source/blender/blenkernel/intern/scene.c
@@ -1123,7 +1123,7 @@ char *BKE_scene_find_last_marker_name(Scene *scene, int 
frame)
 
 Base *BKE_scene_base_add(Scene *sce, Object *ob)
 {
-       Base *b = MEM_callocN(sizeof(*b), "BKE_scene_base_add");
+       Base *b = MEM_callocN(sizeof(*b), __func__);
        BLI_addhead(&sce->base, b);
 
        b->object = ob;
diff --git a/source/blender/editors/space_outliner/outliner_tools.c 
b/source/blender/editors/space_outliner/outliner_tools.c
index f3235d0..253e818 100644
--- a/source/blender/editors/space_outliner/outliner_tools.c
+++ b/source/blender/editors/space_outliner/outliner_tools.c
@@ -516,23 +516,16 @@ static void group_linkobs2scene_cb(
        Group *group = (Group *)tselem->id;
        GroupObject *gob;
        Base *base;
-       
+
        for (gob = group->gobject.first; gob; gob = gob->next) {
                base = BKE_scene_base_find(scene, gob->ob);
-               if (base) {
-                       base->object->flag |= SELECT;
-                       base->flag |= SELECT;
-               }
-               else {
+               if (!base) {
                        /* link to scene */
-                       base = MEM_callocN(sizeof(Base), "add_base");
-                       BLI_addhead(&scene->base, base);
-                       base->lay = gob->ob->lay;
-                       gob->ob->flag |= SELECT;
-                       base->flag = gob->ob->flag;
-                       base->object = gob->ob;
+                       base = BKE_scene_base_add(scene, gob->ob);
                        id_lib_extern((ID *)gob->ob); /* in case these are from 
a linked group */
                }
+               base->object->flag |= SELECT;
+               base->flag |= SELECT;
        }
 }

_______________________________________________
Bf-blender-cvs mailing list
[email protected]
https://lists.blender.org/mailman/listinfo/bf-blender-cvs

Reply via email to