Commit: 1b1c834d7408702654156a10a6ea9721ae8227fc
Author: Campbell Barton
Date:   Wed Mar 8 04:50:45 2017 +1100
Branches: temp-select-pick
https://developer.blender.org/rB1b1c834d7408702654156a10a6ea9721ae8227fc

Fix incorrect extern, also remove redundant rect

===================================================================

M       source/blender/editors/transform/transform_manipulator.c

===================================================================

diff --git a/source/blender/editors/transform/transform_manipulator.c 
b/source/blender/editors/transform/transform_manipulator.c
index 40c123d873..dcda83bd41 100644
--- a/source/blender/editors/transform/transform_manipulator.c
+++ b/source/blender/editors/transform/transform_manipulator.c
@@ -1724,14 +1724,14 @@ static int manipulator_selectbuf(ScrArea *sa, ARegion 
*ar, const int mval[2], fl
 {
        View3D *v3d = sa->spacedata.first;
        RegionView3D *rv3d = ar->regiondata;
-       rctf rect, selrect;
+       rcti rect;
        GLuint buffer[64];      // max 4 items per select, so large enuf
        short hits;
        const bool is_picksel = true;
        const bool do_passes = GPU_select_query_check_active();
 
        /* XXX check a bit later on this... (ton) */
-       extern void view3d_winmatrix_set(ARegion *ar, View3D *v3d, rctf *rect);
+       extern void view3d_winmatrix_set(ARegion *ar, View3D *v3d, rcti *rect);
 
        /* when looking through a selected camera, the manipulator can be at the
         * exact same position as the view, skip so we don't break selection */
@@ -1743,15 +1743,13 @@ static int manipulator_selectbuf(ScrArea *sa, ARegion 
*ar, const int mval[2], fl
        rect.ymin = mval[1] - hotspot;
        rect.ymax = mval[1] + hotspot;
 
-       selrect = rect;
-
        view3d_winmatrix_set(ar, v3d, &rect);
        mul_m4_m4m4(rv3d->persmat, rv3d->winmat, rv3d->viewmat);
 
        if (do_passes)
-               GPU_select_begin(buffer, 64, &selrect, 
GPU_SELECT_NEAREST_FIRST_PASS, 0);
+               GPU_select_begin(buffer, 64, &rect, 
GPU_SELECT_NEAREST_FIRST_PASS, 0);
        else
-               GPU_select_begin(buffer, 64, &selrect, GPU_SELECT_ALL, 0);
+               GPU_select_begin(buffer, 64, &rect, GPU_SELECT_ALL, 0);
 
        /* do the drawing */
        if (v3d->twtype & V3D_MANIP_ROTATE) {
@@ -1766,7 +1764,7 @@ static int manipulator_selectbuf(ScrArea *sa, ARegion 
*ar, const int mval[2], fl
        hits = GPU_select_end();
 
        if (do_passes) {
-               GPU_select_begin(buffer, 64, &selrect, 
GPU_SELECT_NEAREST_SECOND_PASS, hits);
+               GPU_select_begin(buffer, 64, &rect, 
GPU_SELECT_NEAREST_SECOND_PASS, hits);
 
                /* do the drawing */
                if (v3d->twtype & V3D_MANIP_ROTATE) {

_______________________________________________
Bf-blender-cvs mailing list
[email protected]
https://lists.blender.org/mailman/listinfo/bf-blender-cvs

Reply via email to