Commit: 2574ee3d3878c8a78fb2ff1955b10ed20f0ad892
Author: Campbell Barton
Date:   Tue Jul 10 17:28:19 2018 +0200
Branches: blender2.8
https://developer.blender.org/rB2574ee3d3878c8a78fb2ff1955b10ed20f0ad892

Image: remove fields option for image sequences

Remove support for loading interlaced image sequences because
its less common now to record interlaced video,
the option to de-interlace video on load remains.

===================================================================

M       source/blender/blenkernel/intern/camera.c
M       source/blender/blenkernel/intern/image.c
M       source/blender/blenkernel/intern/object.c
M       source/blender/blenkernel/intern/texture.c
M       source/blender/blenloader/intern/versioning_260.c
M       source/blender/blenloader/intern/versioning_legacy.c
M       source/blender/editors/space_image/image_buttons.c
M       source/blender/editors/space_image/image_ops.c
M       source/blender/editors/space_image/space_image.c
M       source/blender/makesdna/DNA_image_types.h
M       source/blender/makesdna/DNA_texture_types.h
M       source/blender/makesrna/intern/rna_image.c
M       source/blender/nodes/composite/nodes/node_composite_image.c
M       source/blender/nodes/composite/nodes/node_composite_splitViewer.c
M       source/blender/nodes/composite/nodes/node_composite_viewer.c
M       source/blender/nodes/shader/nodes/node_shader_tex_environment.c
M       source/blender/nodes/shader/nodes/node_shader_tex_image.c
M       source/blender/nodes/texture/nodes/node_texture_image.c

===================================================================

diff --git a/source/blender/blenkernel/intern/camera.c 
b/source/blender/blenkernel/intern/camera.c
index 778eb17f822..4203e0455f8 100644
--- a/source/blender/blenkernel/intern/camera.c
+++ b/source/blender/blenkernel/intern/camera.c
@@ -977,7 +977,6 @@ CameraBGImage *BKE_camera_background_image_new(Camera *cam)
 
        bgpic->scale = 1.0f;
        bgpic->alpha = 0.5f;
-       bgpic->iuser.fie_ima = 2;
        bgpic->iuser.ok = 1;
        bgpic->iuser.flag |= IMA_ANIM_ALWAYS;
        bgpic->flag |= CAM_BGIMG_FLAG_EXPANDED;
diff --git a/source/blender/blenkernel/intern/image.c 
b/source/blender/blenkernel/intern/image.c
index b5abdcae2d4..b6aeebd81a5 100644
--- a/source/blender/blenkernel/intern/image.c
+++ b/source/blender/blenkernel/intern/image.c
@@ -3129,7 +3129,7 @@ static void image_create_multilayer(Image *ima, ImBuf 
*ibuf, int framenr)
 #endif  /* WITH_OPENEXR */
 
 /* common stuff to do with images after loading */
-static void image_initialize_after_load(Image *ima, ImBuf *ibuf)
+static void image_initialize_after_load(Image *ima, ImBuf *UNUSED(ibuf))
 {
        /* Preview is NULL when it has never been used as an icon before.
         * Never handle previews/icons outside of main thread. */
@@ -3137,11 +3137,6 @@ static void image_initialize_after_load(Image *ima, 
ImBuf *ibuf)
                BKE_icon_changed(BKE_icon_id_ensure(&ima->id));
        }
 
-       /* fields */
-       if (ima->flag & IMA_FIELDS) {
-               if (ima->flag & IMA_STD_FIELD) de_interlace_st(ibuf);
-               else de_interlace_ng(ibuf);
-       }
        /* timer */
        BKE_image_tag_time(ima);
 
@@ -4249,7 +4244,7 @@ void BKE_image_pool_release_ibuf(Image *ima, ImBuf *ibuf, 
ImagePool *pool)
 
 int BKE_image_user_frame_get(const ImageUser *iuser, int cfra, int fieldnr, 
bool *r_is_in_range)
 {
-       const int len = (iuser->fie_ima * iuser->frames) / 2;
+       const int len = iuser->frames;
 
        if (r_is_in_range) {
                *r_is_in_range = false;
@@ -4290,7 +4285,7 @@ int BKE_image_user_frame_get(const ImageUser *iuser, int 
cfra, int fieldnr, bool
                if (fieldnr) cfra++;
 
                /* transform to images space */
-               framenr = (cfra + iuser->fie_ima - 2) / iuser->fie_ima;
+               framenr = cfra;
                if (framenr > iuser->frames) framenr = iuser->frames;
 
                if (iuser->cycl) {
diff --git a/source/blender/blenkernel/intern/object.c 
b/source/blender/blenkernel/intern/object.c
index 95e408f593e..14794bd7061 100644
--- a/source/blender/blenkernel/intern/object.c
+++ b/source/blender/blenkernel/intern/object.c
@@ -2480,7 +2480,6 @@ void BKE_object_empty_draw_type_set(Object *ob, const int 
value)
                        ob->iuser->flag |= IMA_ANIM_ALWAYS;
                        ob->iuser->frames = 100;
                        ob->iuser->sfra = 1;
-                       ob->iuser->fie_ima = 2;
                }
        }
        else {
diff --git a/source/blender/blenkernel/intern/texture.c 
b/source/blender/blenkernel/intern/texture.c
index ad60e81fe19..c5a208e3aca 100644
--- a/source/blender/blenkernel/intern/texture.c
+++ b/source/blender/blenkernel/intern/texture.c
@@ -233,7 +233,6 @@ void BKE_texture_default(Tex *tex)
        tex->texfilter = TXF_EWA;
        tex->afmax = 8;
        tex->xrepeat = tex->yrepeat = 1;
-       tex->fie_ima = 2;
        tex->sfra = 1;
        tex->frames = 0;
        tex->offset = 0;
@@ -267,7 +266,6 @@ void BKE_texture_default(Tex *tex)
        tex->vn_distm = 0;
        tex->vn_coltype = 0;
 
-       tex->iuser.fie_ima = 2;
        tex->iuser.ok = 1;
        tex->iuser.frames = 100;
        tex->iuser.sfra = 1;
diff --git a/source/blender/blenloader/intern/versioning_260.c 
b/source/blender/blenloader/intern/versioning_260.c
index c405e385e9f..7a032dc3c90 100644
--- a/source/blender/blenloader/intern/versioning_260.c
+++ b/source/blender/blenloader/intern/versioning_260.c
@@ -1254,7 +1254,6 @@ void blo_do_versions_260(FileData *fd, Library 
*UNUSED(lib), Main *bmain)
 
                                                tex->iuser.frames = 1;
                                                tex->iuser.sfra = 1;
-                                               tex->iuser.fie_ima = 2;
                                                tex->iuser.ok = 1;
                                        }
                                }
diff --git a/source/blender/blenloader/intern/versioning_legacy.c 
b/source/blender/blenloader/intern/versioning_legacy.c
index 8dae3b235c2..87fc61a8644 100644
--- a/source/blender/blenloader/intern/versioning_legacy.c
+++ b/source/blender/blenloader/intern/versioning_legacy.c
@@ -380,7 +380,6 @@ static void do_version_ntree_242_2(bNodeTree *ntree)
                                        iuser->sfra = nia->sfra;
                                        iuser->offset = nia->nr-1;
                                        iuser->cycl = nia->cyclic;
-                                       iuser->fie_ima = 2;
                                        iuser->ok = 1;
 
                                        node->storage = iuser;
@@ -389,7 +388,6 @@ static void do_version_ntree_242_2(bNodeTree *ntree)
                                else {
                                        ImageUser *iuser = node->storage = 
MEM_callocN(sizeof(ImageUser), "node image user");
                                        iuser->sfra = 1;
-                                       iuser->fie_ima = 2;
                                        iuser->ok = 1;
                                }
                        }
@@ -1844,13 +1842,8 @@ void blo_do_versions_pre250(FileData *fd, Library *lib, 
Main *bmain)
                                        ima = blo_do_versions_newlibadr(fd, 
lib, tex->ima);
                                        if (tex->imaflag & TEX_ANIM5_)
                                                ima->source = IMA_SRC_MOVIE;
-                                       if (tex->imaflag & TEX_FIELDS_)
-                                               ima->flag |= IMA_FIELDS;
-                                       if (tex->imaflag & TEX_STD_FIELD_)
-                                               ima->flag |= IMA_STD_FIELD;
                                }
                                tex->iuser.frames = tex->frames;
-                               tex->iuser.fie_ima = (char)tex->fie_ima;
                                tex->iuser.offset = tex->offset;
                                tex->iuser.sfra = tex->sfra;
                                tex->iuser.cycl = (tex->imaflag & 
TEX_ANIMCYCLIC_)!=0;
@@ -1864,18 +1857,6 @@ void blo_do_versions_pre250(FileData *fd, Library *lib, 
Main *bmain)
                        for (ma = bmain->mat.first; ma; ma = ma->id.next)
                                if (ma->nodetree)
                                        do_version_ntree_242_2(ma->nodetree);
-
-                       for (sc = bmain->screen.first; sc; sc = sc->id.next) {
-                               ScrArea *sa;
-                               for (sa = sc->areabase.first; sa; sa = 
sa->next) {
-                                       SpaceLink *sl;
-                                       for (sl = sa->spacedata.first; sl; sl = 
sl->next) {
-                                               if (sl->spacetype == 
SPACE_IMAGE) {
-                                                       ((SpaceImage 
*)sl)->iuser.fie_ima = 2;
-                                               }
-                                       }
-                               }
-                       }
                }
 
                if (bmain->subversionfile < 4) {
diff --git a/source/blender/editors/space_image/image_buttons.c 
b/source/blender/editors/space_image/image_buttons.c
index 191f57961c9..1d8c6721b64 100644
--- a/source/blender/editors/space_image/image_buttons.c
+++ b/source/blender/editors/space_image/image_buttons.c
@@ -1000,25 +1000,6 @@ void uiTemplateImage(uiLayout *layout, bContext *C, 
PointerRNA *ptr, const char
                                                col = uiLayoutColumn(layout, 
false);
                                                uiItemR(col, &imaptr, 
"use_deinterlace", 0, IFACE_("Deinterlace"), ICON_NONE);
                                        }
-
-                                       split = uiLayoutSplit(layout, 0.0f, 
false);
-
-                                       col = uiLayoutColumn(split, false);
-                                       /* XXX Why only display 
fields_per_frame only for video image types?
-                                        *     And why allow fields for 
non-video image types at all??? */
-                                       if (BKE_image_is_animated(ima)) {
-                                               uiLayout *subsplit = 
uiLayoutSplit(col, 0.0f, false);
-                                               uiLayout *subcol = 
uiLayoutColumn(subsplit, false);
-                                               uiItemR(subcol, &imaptr, 
"use_fields", 0, NULL, ICON_NONE);
-                                               subcol = 
uiLayoutColumn(subsplit, false);
-                                               uiLayoutSetActive(subcol, 
RNA_boolean_get(&imaptr, "use_fields"));
-                                               uiItemR(subcol, userptr, 
"fields_per_frame", 0, IFACE_("Fields"), ICON_NONE);
-                                       }
-                                       else
-                                               uiItemR(col, &imaptr, 
"use_fields", 0, NULL, ICON_NONE);
-                                       row = uiLayoutRow(col, false);
-                                       uiLayoutSetActive(row, 
RNA_boolean_get(&imaptr, "use_fields"));
-                                       uiItemR(row, &imaptr, "field_order", 
UI_ITEM_R_EXPAND, NULL, ICON_NONE);
                                }
                        }
 
diff --git a/source/blender/editors/space_image/image_ops.c 
b/source/blender/editors/space_image/image_ops.c
index 650b48b3b1c..29d63493a3c 100644
--- a/source/blender/editors/space_image/image_ops.c
+++ b/source/blender/editors/space_image/image_ops.c
@@ -1340,7 +1340,6 @@ static int image_open_exec(bContext *C, wmOperator *op)
                else {
                        iuser->offset = frame_ofs - 1;
                }
-               iuser->fie_ima = 2;
                iuser->scene = scene;
                BKE_image_init_imageuser(ima, iuser);
        }
diff --git a/source/blender/editors/space_image/space_image.c 
b/source/blender/editors/space_image/space_image.c
index 9d89e21289d..650f377787a 100644
--- a/source/blender/editors/space_image/space_image.c
+++ b/source/blender/editors/space_image/space_image.c
@@ -177,7 +177,6 @@ static SpaceLink *image_new(const ScrArea *UNUSED(area), 
const Scene *UNUSED(sce
        simage->flag = SI_SHOW_GPENCIL | SI_USE_ALPHA | SI_COORDFLOATS;
 
        simage->iuser.ok = true;
-       simage->iuser.fie_ima = 2;
        simage->iuser.frames = 100;
        simage->iuser.flag = IMA_SHOW_STEREO | IMA_ANIM_ALWAYS;
 
diff --git a/source/blender/makesdna/DNA_image_types.h 
b/source/blender/makesdna/DNA_image_types.h
index 26d7f089f8b..a7ec121efda 100644
--- a/source/blender/makesdna/DNA_image_types.h
+++ b/source/blender/makesdna/DNA_image_types.h
@@ -51,7 +51,7 @@ typedef struct ImageUser {
        int framenr;                            /* movies, sequences: current 
to display */
        int frames;                                     /* total amount of 
frames to use */
        int offset, sfra;                       /* offset within movie, start 
frame in global time */
-       char fie_ima, cycl;             /* fields/image in movie, cyclic flag */
+       char _pad, cycl;                /* cyclic flag */
        char ok;
 
        char multiview_eye;                     /* multiview current eye - for 
internal use of drawing routines */
@@ -157,8 +157,8 @@ typedef struct Image {
 
 /* Image.flag */
 enum {
-       IMA_FIELDS              = (1 << 0),
-       IMA_STD_FIELD           = (1 << 1),
+       // IMA_FIELDS              = (1 << 0),
+       // IMA_STD_FIELD           = (1 << 1),
 #ifdef DNA_DEPRECATED
        IMA_DO_PREMUL           = (1 << 2),  /* deprecated, should not be used 
*/
 #endif
diff --git a/source/blender/makesdna/DNA_texture_types.h 
b/source/blender/makesdna/DNA_texture_types.h
index ca420195b99..42198e22c6b 100644
--- a/source/blender/makesdna/DNA_texture_types.h
+++ b/source/blender/makesdna/DNA_texture_types.h
@@ -192,7 +192,7 @@ typedef struct Tex {
        short extend;
 
        /* variables disabled, moved to struct iuser */
-       short fie_ima;
+       short _pad0;
        int len;
        int frames, offset, sfra;
 
@@ -319,7 +319,7 @@ typedef struct ColorMapping {
 
 /* imaflag unused, only for version check */
 #ifdef DNA_DEPRECATED_ALLOW
-#define TEX_FIELDS_            8
+// #define TEX_FIELDS_         8
 #define TEX_ANIMCYCLIC_        64
 #define TEX_ANIM5_             128
 #define TEX_ANTIALI_   256
diff --git a/source/blender/makesrna/intern/rna_image.c 
b/source/blender/makesrna/intern/rna_image.c
index 3d12debe0b5..1759eb812e6 100644
--- a/source/blender/makesrna/intern/rna_image.c
+++ b/source/blender/makesrna/intern/rna_image.c
@@ -99,27 +99,6 @@ static void rna_Image_source_set(Pointer

@@ Diff output truncated at 10240 characters. @@

_______________________________________________
Bf-blender-cvs mailing list
[email protected]
https://lists.blender.org/mailman/listinfo/bf-blender-cvs

Reply via email to