Commit: fa0f938b111ffa281865613f80e425c27f3096b3
Author: Clément Foucault
Date:   Fri Aug 3 09:48:28 2018 +0200
Branches: blender2.8
https://developer.blender.org/rBfa0f938b111ffa281865613f80e425c27f3096b3

Eevee: Fix assert with hair drawing

This remove unused clip_block when not needed and the useless ubo bind that
were put there for the sake of not crashing.

===================================================================

M       source/blender/draw/engines/eevee/eevee_materials.c
M       source/blender/draw/engines/eevee/shaders/prepass_vert.glsl

===================================================================

diff --git a/source/blender/draw/engines/eevee/eevee_materials.c 
b/source/blender/draw/engines/eevee/eevee_materials.c
index fd097aa783c..535dce7730a 100644
--- a/source/blender/draw/engines/eevee/eevee_materials.c
+++ b/source/blender/draw/engines/eevee/eevee_materials.c
@@ -1005,12 +1005,10 @@ void EEVEE_materials_cache_init(EEVEE_ViewLayerData 
*sldata, EEVEE_Data *vedata)
                DRWState state = DRW_STATE_WRITE_DEPTH | 
DRW_STATE_DEPTH_LESS_EQUAL | DRW_STATE_WIRE;
                psl->depth_pass = DRW_pass_create("Depth Pass", state);
                stl->g_data->depth_shgrp = 
DRW_shgroup_create(e_data.default_prepass_sh, psl->depth_pass);
-               DRW_shgroup_uniform_block(stl->g_data->depth_shgrp, 
"clip_block", sldata->clip_ubo);
 
                state = DRW_STATE_WRITE_DEPTH | DRW_STATE_DEPTH_LESS_EQUAL | 
DRW_STATE_CULL_BACK;
                psl->depth_pass_cull = DRW_pass_create("Depth Pass Cull", 
state);
                stl->g_data->depth_shgrp_cull = 
DRW_shgroup_create(e_data.default_prepass_sh, psl->depth_pass_cull);
-               DRW_shgroup_uniform_block(stl->g_data->depth_shgrp_cull, 
"clip_block", sldata->clip_ubo);
 
                state = DRW_STATE_WRITE_DEPTH | DRW_STATE_DEPTH_LESS_EQUAL | 
DRW_STATE_CLIP_PLANES | DRW_STATE_WIRE;
                psl->depth_pass_clip = DRW_pass_create("Depth Pass Clip", 
state);
diff --git a/source/blender/draw/engines/eevee/shaders/prepass_vert.glsl 
b/source/blender/draw/engines/eevee/shaders/prepass_vert.glsl
index f2e9e7001e8..e110937c5aa 100644
--- a/source/blender/draw/engines/eevee/shaders/prepass_vert.glsl
+++ b/source/blender/draw/engines/eevee/shaders/prepass_vert.glsl
@@ -2,10 +2,12 @@
 uniform mat4 ModelViewProjectionMatrix;
 uniform mat4 ModelMatrix;
 
+#ifdef CLIP_PLANES
 /* keep in sync with DRWManager.view_data */
 layout(std140) uniform clip_block {
        vec4 ClipPlanes[1];
 };
+#endif
 
 #ifndef HAIR_SHADER
 in vec3 pos;

_______________________________________________
Bf-blender-cvs mailing list
[email protected]
https://lists.blender.org/mailman/listinfo/bf-blender-cvs

Reply via email to