Hi, This was a bugfix to solve crashes when freeing VBO's from other threads, to do it inside the main thread instead. These buffers were previously freed immediately in GPU_buffer_free, this call just delayed them. It doesn't do any more freeing than before as far as I can see, the check > MAX_FREE_GPU_BUFFERS is still there.
Brecht. On Fri, Nov 26, 2010 at 12:20 PM, Lukas Steiblys <[email protected]> wrote: > Revision: 33327 > > http://projects.blender.org/plugins/scmsvn/viewcvs.php?view=rev&root=bf-blender&revision=33327 > Author: imbusy > Date: 2010-11-26 12:20:03 +0100 (Fri, 26 Nov 2010) > > Log Message: > ----------- > freeing all free GPU buffers every frame could be a performance issue and is > not necessary > > Modified Paths: > -------------- > trunk/blender/source/blender/gpu/intern/gpu_draw.c > > Modified: trunk/blender/source/blender/gpu/intern/gpu_draw.c > =================================================================== > --- trunk/blender/source/blender/gpu/intern/gpu_draw.c 2010-11-26 03:58:31 > UTC (rev 33326) > +++ trunk/blender/source/blender/gpu/intern/gpu_draw.c 2010-11-26 11:20:03 > UTC (rev 33327) > @@ -810,7 +810,8 @@ > BLI_freelistN(&image_free_queue); > > /* vbo buffers */ > - GPU_buffer_pool_free_unused(0); > + /* it's probably not necessary to free all buffers every frame */ > + /* GPU_buffer_pool_free_unused(0); */ > > BLI_unlock_thread(LOCK_OPENGL); > } > > > _______________________________________________ > Bf-blender-cvs mailing list > [email protected] > http://lists.blender.org/mailman/listinfo/bf-blender-cvs > _______________________________________________ Bf-committers mailing list [email protected] http://lists.blender.org/mailman/listinfo/bf-committers
