I fixed the issues with the patch and uploaded it to the tracker: http://projects.blender.org/tracker/index.php?func=detail&aid=25901&group_id=9&atid=127
The only thing that is missing is a check for older files. (See the description on the tracker for further information) I still need to find out, where the Bone structs getting allocated while opening and existing file. A small check for "0" and one initial computation with the current method should do the job. Any files that are stored afterwards will be fine, since the check will always fail. Am 01.02.2011 18:47, schrieb Brecht Van Lommel: > Hi, > > This patch and the other one you posted contain many formatting > changes, please keep those out of patches, it's hard to see what you > changed. > > Regarding this fix, it would be better to store original > roll/head/tail + loc/rot/scale on entering edit mode in the EditBone, > and then use that when you convert back from EditBone to Bone, if the > roll/head/tail didn't change (maybe need to check for parent changes > too). That keeps it nice localized. Better not store duplicate state > in files, not because of memory usage, but because it's better to keep > such hacks in runtime code. > > Brecht. > > On Tue, Feb 1, 2011 at 6:36 PM, Stephen Swaney<[email protected]> wrote: >> On Tue, Feb 01, 2011 at 06:04:59PM +0100, Tobias Oelgarte wrote: >>> The patch: >>> * http://pastebin.com/mV5BwHqW >> Blender has a Patch Tracker. Putting patches in our tracker >> makes it easier to review and maintain them. >> >> Making it easier for patch reviewers is making it easier to >> get your patch applied. >> >> -- >> Stephen Swaney >> [email protected] >> >> _______________________________________________ >> Bf-committers mailing list >> [email protected] >> http://lists.blender.org/mailman/listinfo/bf-committers >> > _______________________________________________ > Bf-committers mailing list > [email protected] > http://lists.blender.org/mailman/listinfo/bf-committers > _______________________________________________ Bf-committers mailing list [email protected] http://lists.blender.org/mailman/listinfo/bf-committers
