> Some comments on the code: > > The image buffer should be marked as modified: ibuf->userflags |= > IB_BITMAPDIRTY;
done. >> + RNA_def_boolean(ot->srna, "inv_r", 0, "Red", "Invert Red Channel"); >> + RNA_def_boolean(ot->srna, "inv_g", 0, "Green", "Invert Green >> Channel"); >> + RNA_def_boolean(ot->srna, "inv_b", 0, "Blue", "Invert Blue Channel"); >> + RNA_def_boolean(ot->srna, "inv_a", 0, "Alpha", "Invert Alpha >> Channel"); > > No need to use abbreviations here, change inv_ to invert_. done. >> - /* properties */ >> - RNA_def_enum(ot->srna, "method", unpack_method_items, PF_USE_LOCAL, >> "Method", "How to unpack."); >> - RNA_def_string(ot->srna, "id", "", 21, "Image Name", "Image >> datablock name to unpack."); /* XXX, weark!, will fail with library, name >> collisions */ >> } > > Was this intentional, those properties still seem to be used in the > unpack operator? not at all intentional. thanks for spotting this one! r35115 cheers, lmg -- all efforts are waste without copy and paste. tho make sure not fsck up copy and cut! _______________________________________________ Bf-committers mailing list [email protected] http://lists.blender.org/mailman/listinfo/bf-committers
