Hey Campbell, well with this commit you undo my fix for a very common case. :) I see that my solution didn't worked for when the player was in users $PATH so it's good you fixed that, but your solution doesn't work when you don't have a player in $PATH and the user pref field is empty too.
Bottom line: After your commit a user (again) does not get an error when he starts Blender and calls the operator (here on Windows, with no Blender in $PATH). He instead wonders why nothing happens. Which is excactly what I wanted to avoid/fix! ;-) Best regards, Thomas Am 25.07.2011 08:38, schrieb Campbell Barton: > Revision: 38681 > > http://projects.blender.org/scm/viewvc.php?view=rev&root=bf-blender&revision=38681 > Author: campbellbarton > Date: 2011-07-25 06:38:21 +0000 (Mon, 25 Jul 2011) > Log Message: > ----------- > fix for DingTo's recent commit with the animation player, it ignored the case > where the player is not an absolute path but found in the users $PATH (as is > common on *nix systems). > > now try and execute player, reporting the exception rather then checking the > player file exists. > also made some pep8-80 style edits. > -- Thomas Dinges Blender Developer, Artist and Musician www.dingto.org _______________________________________________ Bf-committers mailing list [email protected] http://lists.blender.org/mailman/listinfo/bf-committers
