Hi, I'll agree that having code guidelines will help on keeping code more consistent. Don't think existing code should be changed to some general rule, but prefer to have newly adding code following the same style. Long lines are also better be prevented, imo. They might have sense for long URL or code from stubs.c, but in general prefer to avoid long lines too. It's easy to do.
About code guidelines itself.. Not sure which style should be takes as base, perhaps any style might be takes as basis, after this we'll write guideline in the wiki and can discuss it a bit before declaring it as "standard" IMO, most important to define would be: - Indentation rules (when line is getting split) - Comment style - Variables naming - Variables declaration style I've got some guidelines we've been using in some projects (not Blender related, it was done before i've joined Blender community). Think i might use them as basis, check which style is using by active developers and prepare first version of blender code guideline in wiki. Think on monday we'll might start discussion of that guidelines draft. On Fri, Dec 16, 2011 at 8:34 AM, Campbell Barton <[email protected]>wrote: > This is not high priority of course but once in a while I notice > blender has some annoyingly long lines in our own source dir, eg. > > http://www.graphicall.org/ftp/ideasman42/long_lines.png > > Eventually it could be good to have a document like this for blender: > https://sites.google.com/site/openimageio/coding-style-guide > > ... until then, I'd like to set some reasonable line limit - Suggest > 120 (80 would be is impracticable for us). > > longer lines can stay where it makes sense - URL's for example. > > -- > - Campbell > _______________________________________________ > Bf-committers mailing list > [email protected] > http://lists.blender.org/mailman/listinfo/bf-committers > -- With best regards, Sergey Sharybin _______________________________________________ Bf-committers mailing list [email protected] http://lists.blender.org/mailman/listinfo/bf-committers
