+1 for more generic headers, this was on my todo, http://wiki.blender.org/index.php/User:Ideasman42#Code_Refactoring - second point :)
the file is in fact in 3 places if you count superlu_sys_types.h On Mon, Dec 26, 2011 at 6:54 PM, Sergey Sharybin <[email protected]> wrote: > Hi, > > I'd say it's not actually nice solution. The best solution i might think > about is: > > Use some kind of portable stdint.h placed in extern/ so ffmpeg, carve (and > probably other libraries) might use it. This file would also be used by > MEM_sys_types.h (didn't check it deeper, probably this file could be just > eliminated). In blender sources define common header file (like in blenlib) > which would be used for stuff like this (to avoid including extern/ stuff > directly and make it possible to extend this include file with other > types/macros and so on). > > On Mon, Dec 26, 2011 at 3:27 AM, Campbell Barton <[email protected]>wrote: > >> Revision: 42871 >> >> http://projects.blender.org/scm/viewvc.php?view=rev&root=bf-blender&revision=42871 >> Author: campbellbarton >> Date: 2011-12-25 21:27:23 +0000 (Sun, 25 Dec 2011) >> Log Message: >> ----------- >> include BLO_sys_types in customdata header rather than stdint directly. >> >> Modified Paths: >> -------------- >> trunk/blender/source/blender/blenkernel/BKE_customdata.h >> >> Modified: trunk/blender/source/blender/blenkernel/BKE_customdata.h >> =================================================================== >> --- trunk/blender/source/blender/blenkernel/BKE_customdata.h 2011-12-25 >> 19:42:26 UTC (rev 42870) >> +++ trunk/blender/source/blender/blenkernel/BKE_customdata.h 2011-12-25 >> 21:27:23 UTC (rev 42871) >> @@ -34,14 +34,12 @@ >> #ifndef BKE_CUSTOMDATA_H >> #define BKE_CUSTOMDATA_H >> >> -#if defined(__APPLE__) && (__GNUC__ == 4) && (__GNUC_MINOR__ >= 6) >> -#include <stdint.h> >> -#endif >> - >> #ifdef __cplusplus >> extern "C" { >> #endif >> >> +#include "../blenloader/BLO_sys_types.h" /* XXX, should have a more >> generic include for this */ >> + >> struct ID; >> struct CustomData; >> struct CustomDataLayer; >> >> _______________________________________________ >> Bf-blender-cvs mailing list >> [email protected] >> http://lists.blender.org/mailman/listinfo/bf-blender-cvs >> > > > > -- > With best regards, Sergey Sharybin > _______________________________________________ > Bf-committers mailing list > [email protected] > http://lists.blender.org/mailman/listinfo/bf-committers -- - Campbell _______________________________________________ Bf-committers mailing list [email protected] http://lists.blender.org/mailman/listinfo/bf-committers
