first of all congrats for the project and your work over the last couple 
of years! :)

Although I understand the need and the users want this in trunk I am a 
bit sceptical of the integration.

Basically I would prefer to see Freestyle being implemented as an 
external engine rather than hook so deep into Blenders core.
I mean that was the intention of the API, to make exactly that possible.

 From a quick look at the patch it looks like its quite heavily 
integrated. What is the intention of the ID_LS you added?
Also I don't see a way to disable freestyle (compile option).

Sorry but at the moment I would not recommend a merge. Basically I first 
would like to check if it would be possible to integrate it via the 
Render API, and with much less changes to the core.


Am 22.05.2012 03:17, schrieb Tamito KAJIYAMA:
> Nicholas,
> Here is a quick attempt of diff -ruN against the trunk revision 46787.
> http://www.asahi-net.or.jp/~rd6t-kjym/tmp/diff_against_trunk_r46787.zip
> The patch consists of 98070 lines.  Of these, source/blender/freestyle/ 
> (83932 lines) and
> release/scripts/freestyle/ (6239 lines) are C/C++ code and Python scripts, 
> respectively,
> based on the code from the original Freestyle program.  The rest of the diff 
> (7899 lines)
> concerns changes to the Blender code base.  The changes mainly reside in the 
> following
> directories:
> release/scripts/startup/bl_operators/
> release/scripts/startup/bl_ui/
> source/blender/blenkernel/
> source/blender/blenlib/
> source/blender/blenloader/
> source/blender/bmesh/
> source/blender/editors/
> source/blender/makesdna/
> source/blender/makesrna/
> source/blender/python/
> source/blender/render/
> source/blender/windowmanager/
> source/blenderplayer/
> source/creator/
> Regards,

Thomas Dinges
Blender Developer, Artist and Musician


Bf-committers mailing list

Reply via email to