Well, it's really tricky to glue together several git commits before passing them to git-svn. Easy to mess up really important stuff. Personally i can't see what's bad in this case.
On Wed, May 23, 2012 at 12:06 AM, Thomas Dinges <[email protected]> wrote: > For the record, > commiting a feature in several commits is okay if it makes sense...but > in this case, 1 extra commit for the icon, one for theme > colors...seriously? > > Thanks! > > Am 22.05.2012 17:19, schrieb Nicholas Bishop: > > Revision: 46886 > > > http://projects.blender.org/scm/viewvc.php?view=rev&root=bf-blender&revision=46886 > > Author: nicholasbishop > > Date: 2012-05-22 15:19:13 +0000 (Tue, 22 May 2012) > > Log Message: > > ----------- > > Add skin modifier icon created by Julio Iglesias. > > > > Skin modifier documentation: > > http://wiki.blender.org/index.php/User:Nicholasbishop/SkinModifier > > > > Modified Paths: > > -------------- > > trunk/blender/release/datafiles/blender_icons.png > > trunk/blender/source/blender/editors/datafiles/blender_icons.png.c > > trunk/blender/source/blender/editors/include/UI_icons.h > > > > > -- > Thomas Dinges > Blender Developer, Artist and Musician > > www.dingto.org > > _______________________________________________ > Bf-committers mailing list > [email protected] > http://lists.blender.org/mailman/listinfo/bf-committers > -- With best regards, Sergey Sharybin _______________________________________________ Bf-committers mailing list [email protected] http://lists.blender.org/mailman/listinfo/bf-committers
