I just merged trunk changes including r54141 into the Freestyle branch. Thanks a lot for the problem report and the fix!
With best regards, -- KAJIYAMA, Tamito <[email protected]> -----Original Message----- From: IRIE Shinsuke Sent: Monday, January 28, 2013 11:19 AM To: Bastien Montagne ; bf-blender developers Subject: Re: [Bf-committers] Freestyle branch: Cycles render layer UI broken Thanks for the fix! Merged Freestyle into trunk locally and confirmed it works fine. IRIE Shinsuke 13/01/28, Bastien Montagne wrote: > Hi Irie, > > Fix is in trunk (r54141), will be in freestyle at the next merge! ;) > > Thanks again for spotting this issue. :) > > Cheers, > Bastien > > On 27/01/2013 19:06, Bastien Montagne wrote: >> Very good point! That’s indeed a glitch that needs to be fixed in trunk >> itself, as it may affect any panel, will do asap! Thanks >> for spotting it. :) >> >> On 27/01/2013 18:24, IRIE Shinsuke wrote: >>> If I start Blender with --factory-startup option, the problem doesn't >>> happen. My startup file seems to have "panel closed" flag for the >>> render layers panel. >>> >>> Probably you can reproduce the problem as follows: >>> >>> 1. Remove "bl_options = {'HIDE_HEADER'}" and do "make install" >>> 2. Start blender with --factory-startup option >>> 3. Change renderer to Cycles, and close the render layers panel >>> 4. Save a .blend file >>> 5. Revert the step 1 >>> 6. Start blender and load the .blend file above >>> >>> Then, the panel shouldn't appear. >>> >>> I think the "panel closed" flag should be ignored if the HIDE_HEADER >>> option is given. >>> >>> IRIE Shinsuke >>> >>> 13/01/28, Bastien Montagne wrote: >>>> That's really weird… Do you have the other controls in this panel (buttons >>>> to the side of the list, text field below it), or >>>> do you have a completely empty panel? >>>> >>>> Hiding header should not affect at all panel's content… >>>> >>>> And the same panel with internal works OK? (because they have exactly the >>>> same code!) o_O >>>> >>>> If draw() is really not called, then I think we have some kind of bug >>>> unrelated to freestyle… but can't do much if I can't >>>> reproduce it :( >>>> >>>> On 27/01/2013 17:26, IRIE Shinsuke wrote: >>>>> Ah, the render layer list appears if I removed >>>>> "bl_options = {'HIDE_HEADER'}" in CyclesRender_PT_layers. >>>>> >>>>> Otherwise, draw() in CyclesRender_PT_layers seems not to be called. >>>>> >>>>> IRIE Shinsuke >>>>> >>>>> 13/01/28, IRIE Shinsuke wrote: >>>>>> Strange... >>>>>> >>>>>> Of course I did "make install" and confirmed that ui.py has been >>>>>> updated. (The issue (2) indeed has been fixed.) >>>>>> >>>>>> And I got no error in console. >>>>>> >>>>>> IRIE Shinsuke >>>>>> >>>>>> 13/01/27, Bastien Montagne wrote: >>>>>>> That’s rather odd… For me it works OK, see >>>>>>> http://www.pasteall.org/pic/44360 … >>>>>>> >>>>>>> I suppose you did make install ? ;) >>>>>>> >>>>>>> Also, could you have a look to your blender's console, there shoud be >>>>>>> some error message here! :) >>>>>>> >>>>>>> On 27/01/2013 15:34, IRIE Shinsuke wrote: >>>>>>>> Thanks, but unfortunately the issue (1) still isn't fixed... >>>>>>>> Could you look into it again? >>>>>>>> >>>>>>>> IRIE Shinsuke >>>>>>>> >>>>>>>> 13/01/27, Bastien Montagne wrote: >>>>>>>>> Hi Irie, and thanks for the report! Should be fixed in r54119. :) >>>>>>>>> >>>>>>>>> Best regards, >>>>>>>>> Bastien >>>>>>>>> >>>>>>>>> On 27/01/2013 13:35, IRIE Shinsuke wrote: >>>>>>>>>> Tamito, in Freestyle build, render layer panel is not correctly shown >>>>>>>>>> when using Cycles: >>>>>>>>>> >>>>>>>>>> (1) Render layer list doesn't appear, so we cannot create a scene >>>>>>>>>> that >>>>>>>>>> uses multiple render layers. >>>>>>>>>> >>>>>>>>>> (2) Label "Layer" is used twice for panel headers. That's confusing. >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> r54113 >>>>>>>>>> Ubuntu 12.10 >>>>>>>>>> >>>>>>>> >>>>> >>> >> _______________________________________________ Bf-committers mailing list [email protected] http://lists.blender.org/mailman/listinfo/bf-committers _______________________________________________ Bf-committers mailing list [email protected] http://lists.blender.org/mailman/listinfo/bf-committers
