Hi. Sorry, i hope you dont take what i write personally. Just defending the patch.
Sorry. I cant help myself. "Would you consider updating your patch to align the header titles when the triangles are removed? The lack of header alignment is the bigger issue there.. It is hard to fix well with the triangles in place but easy once they are removed. Harley can send you a mock if its needed." Yea, sure. If an 'align header label patch' is complete, they can both be added together. Looking at the code, an 'align header label patch' can be added later. So, this can still be committed, then the 'align header label patch' can be added later. I guess they would look something like these. http://www.pasteall.org/pic/show.php?id=55461 koil > Date: Thu, 11 Jul 2013 17:54:01 -0700 > From: [email protected] > To: [email protected] > Subject: Re: [Bf-committers] Patch: Panel Show Triangle > > On Jul 11, 2013 12:14 PM, "koil ." <[email protected]> wrote: > > So far i see no reason why this patch should not be committed. > > This patch is progress towards the UI designs on the thread. > > You make a fine point.. > > Would you consider updating your patch to align the header titles when the > triangles are removed? > > The lack of header alignment is the bigger issue there.. It is hard to fix > well with the triangles in place but easy once they are removed. Harley can > send you a mock if its needed. > _______________________________________________ > Bf-committers mailing list > [email protected] > http://lists.blender.org/mailman/listinfo/bf-committers _______________________________________________ Bf-committers mailing list [email protected] http://lists.blender.org/mailman/listinfo/bf-committers
