Hi Brecht, I will leave things as they are then. 1 Key + HOME Key get me where I wanted (image 1:1 fullscreen). By the way, I suspect the fit_view code is distorting the image.
The following lines produce 1681x1051: width = BLI_rcti_size_x(&ar->winrct) + 1; height = BLI_rcti_size_x(&ar->winrct) + 1; And even if you set border to 0 you can see that the result from fit_view (F) and 1:1 (1 + HOME) differ. At least for OSX we probably need something like: http://www.pasteall.org/45007/diff (note that without this patch the """(width > 0 && height > 0)""" test is pretty much useless) (feel free to change the patch and commit if you think it's correct) Dalai -- blendernetwork.org/dalai-felinto www.dalaifelinto.com 2013/8/20 Brecht Van Lommel <[email protected]> > The HOME option as it works now is something I use a lot. It could work > better but at least for me it's important to have something that always > gives power-of-two zoom levels, the distortion from other zoom levels is > just too misleading to inspect render or compositing results. I'm not sure > if that's just me or if users do the same. > > Without a border it's also not really clear which pixels are part of the > render and which are part of the UI, a bit of padding looks better. If > you're in fullscreen and the image fits in the screen then HOME / F can > display without borders, but otherwise I'm not sure it's better. > > > > On Wed, Aug 21, 2013 at 1:51 AM, Dalai Felinto <[email protected]> wrote: > > > Hi all > > (Sergey in particular), > > > > I fixed the 'View All' operator for the Clip editor and incremented the > one > > for the Image Editor (rev. 59338, 59339). There are still some > improvements > > I would like to address. > > > > Basically we can activate the 'View All' operator in two ways: > > > > HOMEKey - View All (shows the image within a big border) > > FKey - View All + fit_view (shows the image fitting *almost* on the > > fullscreen. > > > > 1) Can we get rid of the 'HOME' option? > > > > Since at least for me I always need the image to fit the editor. (if so > we > > can even remove the F shortcut and have the HOME one to call the operator > > with "fit_view" always on). > > > > 2) When calling FKey there is a border of 5 pixels around the image, can > > the border be of ZERO? > > > > This would make fullscreen to really be fullscreen - so a fullHD image > can > > map 1:1 to a fullHD display. I understand if someone advocates for the > clip > > editor since the bottom of the editor is used to display the tracked > > frames. But at least for the Image editor border ZERO would be better. > > > > > > Thanks, > > Dalai > _______________________________________________ Bf-committers mailing list [email protected] http://lists.blender.org/mailman/listinfo/bf-committers
