Sorry for the noise. I thought i messed up something but actually all is well.
Although the story behind it is a bit odd:

The breakage actually happened with commit 6febe6e72 which was labelled "Silence warning from Collada". The commit slipped through my attention (my fault) so i was not aware of it and so i did not report it to be added to 2.79a. But even when i had looked at the git show 6febe6e72 i would have considered this a very innocent change. You only can see the mess when you look at the sources in this case.

Well, the good news is the breaking commit did not arrive at the 2.79a branch, i found it in master and fixed it also in blender2.8 and all is well now :)

cheers,
Gaia


On 02.02.2018 10:36, Bastien Montagne wrote:
Eeeeeh… for some reason, we don't have same code in 2.79a and master for DocumentWriter.cpp, and that issue is not present in 2.79a afaict. Would be nice if you could double-check that though. But rB78a77fe622b8 does not apply cleanly and is not needed on 2.79a imho.

Bastien


Le 02/02/2018 à 01:03, Gaia Clary a écrit :
i found a nasty mistake in one of my recent fixes where i have unintentionally commented out 2 lines which now disable Collada animation export. Please can you consider to add this fix to 2.79a?

rB78a77fe622b8 -- fix: unintentionally commented out collada animation export

thanks,
Gaia


On 23.01.2018 12:41, Sergey Sharybin wrote:
Hi everyone,

A huge work was done to port crucial fixes (and even more!), and we are
ready for 2.79a Release Candidate now.

Yes, that's right. There are so much things that changed, that we do an
extra steps for corrective release, something we didn't do before.

Full list of changes can be found there:
https://developer.blender.org/T53683
We will work on a better release page shortly.

Information for platform maintainers:

- Build from the blender-2.79a-release branch,
SHA 61335d853d113c827a54ab3b71e357fab2aa507a
- Addons revision: cf60d1ad47622f85d8294609198de482fb8c4f22
- Locale revision: 1bbc9bdabe4ed26c164aef8a43ef39657dc23cfb
- Libraries SVN tag: blender-2.79a-release

Suggested name: blender-2.79a-rc-<platform>

Make sure you're using 2.79a tag for libraries.

Put builds to usual location and let me know when they are ready.,

Special thanks to Bastien Montagne for coordinating 2.79a, and everyone
else who invested their time on porting fixes to the branch!


_______________________________________________
Bf-committers mailing list
Bf-committers@blender.org
https://lists.blender.org/mailman/listinfo/bf-committers


_______________________________________________
Bf-committers mailing list
Bf-committers@blender.org
https://lists.blender.org/mailman/listinfo/bf-committers

_______________________________________________
Bf-committers mailing list
Bf-committers@blender.org
https://lists.blender.org/mailman/listinfo/bf-committers

Reply via email to