Dear all. As discussed a couple of times here and in the IRC chat, it is best to separate the importer/exporters from the panel. This is what I have done in the last weeks.
So, we have three addons: the PDB and XYZ Import/Export addons and the addon, which loads the panel. I followed all suggestions from Campbell mentioned here, http://codereview.appspot.com/6815052 , and could solve almost all issues. I also tried to be compatible with the "Style guide for Python code" (http://www.python.org/dev/peps/pep-0008/). Furthermore, I found a few bugs. I tested the addons extensively, and they seem to be in a very good shape. The addons are 'ready' for, may be, a second review. Thanks for all comments, and your first review, Campbell, cheers, Blendphys. > Dear Campbell. > >> We don't have to be totally strict about where addons put panels and >> knit picks, but think its worth attempting to make addons fit in with >> blender and not overload addons with too much functionality. >> > Well, I see the point: separating things. > >> but ideally IMHO, there would be an addon for import/export >> and thats all it would do, >> then if you wanted to have some panel with a bunch of various tools >> this could be an addon distributed separately. > If so, the best is to also modify the PDB addon since the same panel > appears after importing a PDB file. > > 2 IOs + one panel for both. The panel needs then to be reduced, too: > The part that helps 'reloading' structures wouldn't work anymore > (and can be principally removed since we have shift+d). > > All this is possible, however, only in view of ... >> I realize in practice this is more effort to integrate. > ... the point you are mentioning: time. > > Furthermore: If we do all this, will the panel be also in trunc? If not, > a user has to activate the two IOs, pdb and xyz, and then he has to > install separately the panel - a solution I consider as 'complicated'. > >> For now, if you have time for this is best to make the obvious >> improvements suggested in the code review and leave areas you are >> uncertain about. > Okay. What about: First focusing on the XYZ IO and trying to separate the > importer from the panel. Meanwhile, I could fix some of the improvements > suggested. How shall the panel be named? 'add_atomic_blender_panel.py'? > > Cheers, > > Blendphys. > > > > _______________________________________________ > Bf-python mailing list > [email protected] > http://lists.blender.org/mailman/listinfo/bf-python _______________________________________________ Bf-python mailing list [email protected] http://lists.blender.org/mailman/listinfo/bf-python
