Revision: 11118
http://bibdesk.svn.sourceforge.net/bibdesk/?rev=11118&view=rev
Author: amaxwell
Date: 2007-09-21 15:22:34 -0700 (Fri, 21 Sep 2007)
Log Message:
-----------
Allow the user to target a specific drop row with any file, rather than
sniffing the pasteboard during the drag. This is a partial workaround for bug
#1799630.
Modified Paths:
--------------
trunk/bibdesk/BibDocument_DataSource.m
Modified: trunk/bibdesk/BibDocument_DataSource.m
===================================================================
--- trunk/bibdesk/BibDocument_DataSource.m 2007-09-21 16:07:41 UTC (rev
11117)
+++ trunk/bibdesk/BibDocument_DataSource.m 2007-09-21 22:22:34 UTC (rev
11118)
@@ -777,7 +777,9 @@
// set drop row to -1 and NSTableViewDropOperation to
NSTableViewDropOn, when we don't target specific rows
http://www.corbinstreehouse.com/blog/?p=123
if(row == -1 || op == NSTableViewDropAbove){
[tv setDropRow:-1 dropOperation:NSTableViewDropOn];
- }else if(([type isEqualToString:NSFilenamesPboardType] == NO ||
[[info draggingPasteboard] containsUnparseableFile] == NO) &&
+ }
+ // We were checking -containsUnparseableFile here as well, but I think
it makes sense to allow the user to target a specific row with any file type
(including BibTeX). Further, checking -containsUnparseableFile can be
unacceptably slow (see bug #1799630), which ruins the dragging experience.
+ else if(([type isEqualToString:NSFilenamesPboardType] == NO) &&
[type isEqualToString:BDSKWeblocFilePboardType] == NO &&
[type isEqualToString:NSURLPboardType] == NO){
[tv setDropRow:-1 dropOperation:NSTableViewDropOn];
}
This was sent by the SourceForge.net collaborative development platform, the
world's largest Open Source development site.
-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2005.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
Bibdesk-commit mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/bibdesk-commit
