Revision: 11518
http://bibdesk.svn.sourceforge.net/bibdesk/?rev=11518&view=rev
Author: amaxwell
Date: 2007-11-09 14:24:24 -0800 (Fri, 09 Nov 2007)
Log Message:
-----------
reduce number of #warnings, add comments
Modified Paths:
--------------
trunk/bibdesk/BDSKWebGroupViewController.m
Modified: trunk/bibdesk/BDSKWebGroupViewController.m
===================================================================
--- trunk/bibdesk/BDSKWebGroupViewController.m 2007-11-09 21:32:22 UTC (rev
11517)
+++ trunk/bibdesk/BDSKWebGroupViewController.m 2007-11-09 22:24:24 UTC (rev
11518)
@@ -186,6 +186,7 @@
NSArray *newPubs = [BDSKWebParser itemsFromDocument:domDocument
fromURL:url error:&error];
if (nil == newPubs) {
#warning remove for release
+ // !!! logs are here to help diagnose problems that users are reporting
NSLog(@"-[%@ [EMAIL PROTECTED] %@", [self class],
NSStringFromSelector(_cmd), error);
[NSApp presentError:error];
}
@@ -200,13 +201,14 @@
}
- (void)webView:(WebView *)sender didFailProvisionalLoadWithError:(NSError
*)error forFrame:(WebFrame *)frame{
-#warning is this really a failure?
+#warning FIXME: is this really a failure?
+ // arm: I'm not sure what the provisional load failure implies; from the
docs it sounds like things will continue loading, so do we really want to kill
things here? If anyone knows or has a test case for this, please comment.
if (frame == loadingWebFrame) {
[self setRetrieving:NO];
[group addPublications:nil];
loadingWebFrame = nil;
}
-#warning remove for release
+ // !!! logs are here to help diagnose problems that users are reporting
NSLog(@"-[%@ [EMAIL PROTECTED] %@", [self class],
NSStringFromSelector(_cmd), error);
}
@@ -216,7 +218,7 @@
[group addPublications:nil];
loadingWebFrame = nil;
}
-#warning remove for release
+ // !!! logs are here to help diagnose problems that users are reporting
NSLog(@"-[%@ [EMAIL PROTECTED] %@", [self class],
NSStringFromSelector(_cmd), error);
[NSApp presentError:error];
}
This was sent by the SourceForge.net collaborative development platform, the
world's largest Open Source development site.
-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems? Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/
_______________________________________________
Bibdesk-commit mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/bibdesk-commit
