Revision: 22547
http://sourceforge.net/p/bibdesk/svn/22547
Author: hofman
Date: 2018-08-30 14:00:41 +0000 (Thu, 30 Aug 2018)
Log Message:
-----------
clean up group outline view in windowWillClose:, because it retains the groups,
do this early before the dataSource is disconnected
Modified Paths:
--------------
trunk/bibdesk/BibDocument.m
Modified: trunk/bibdesk/BibDocument.m
===================================================================
--- trunk/bibdesk/BibDocument.m 2018-08-30 06:30:30 UTC (rev 22546)
+++ trunk/bibdesk/BibDocument.m 2018-08-30 14:00:41 UTC (rev 22547)
@@ -680,7 +680,13 @@
[[BDSKPreviewer sharedPreviewer] updateWithoutBibTeXString];
[previewer terminate];
}
-
+
+ // always release these on the main thread, many need cleanup on the main
thread,
+ // and having dispatch_sync for every one seperately is inefficient
+ BDSKDESTROY(groups);
+ // the outline view retains its items, so clean them up as well
+ [groupOutlineView reloadData];
+
[pboardHelper setDelegate:nil];
[pboardHelper release];
pboardHelper = nil;
@@ -721,10 +727,6 @@
// this was retained because it can be swapped in/out
[[tableView enclosingScrollView] release];
- // always release these on the main thread, many need cleanup on the main
thread,
- // and having dispatch_sync for every one seperately is inefficient
- BDSKDESTROY(groups);
-
// safety call here, in case the pasteboard is retaining the document; we
don't want notifications after the window closes, since all the pointers to UI
elements will be garbage
[[NSNotificationCenter defaultCenter] removeObserver:self];
}
This was sent by the SourceForge.net collaborative development platform, the
world's largest Open Source development site.
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Bibdesk-commit mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/bibdesk-commit
