[Bibdesk-commit] SF.net SVN: bibdesk:[22570] trunk/bibdesk/BDSKArxivParser.m

[hofman--- via Bibdesk-commit]

Revision: 22570
          http://sourceforge.net/p/bibdesk/svn/22570
Author:   hofman
Date:     2018-09-09 14:46:43 +0000 (Sun, 09 Sep 2018)
Log Message:
-----------
add pdf url if not found rather than instead of abstract url

Modified Paths:
--------------
    trunk/bibdesk/BDSKArxivParser.m

Modified: trunk/bibdesk/BDSKArxivParser.m
===================================================================
--- trunk/bibdesk/BDSKArxivParser.m     2018-09-09 14:31:39 UTC (rev 22569)
+++ trunk/bibdesk/BDSKArxivParser.m     2018-09-09 14:46:43 UTC (rev 22570)
@@ -179,11 +179,10 @@
         // search for arXiv ID
         node = [arxivLinkNode singleNodeForXPathExpression:arxivIDNodePath];
         if (node) {
-            NSString *eprint = nil;
-            if ((eprint = [node stringValue])) {
-                if ([eprint hasCaseInsensitivePrefix:@"arXiv:"])
-                    eprint = [string substringFromIndex:6];
-                [pubFields setValue:eprint forKey:@"Eprint"];
+            if ((string = [node stringValue])) {
+                if ([string hasCaseInsensitivePrefix:@"arXiv:"])
+                    string = [string substringFromIndex:6];
+                [pubFields setValue:string forKey:@"Eprint"];
             }
             if ((string = [node stringValueOfAttribute:@"href"])) {
                 // fix relative urls
@@ -193,13 +192,6 @@
                     [pubFields setValue:string forKey:BDSKUrlString];
                 if (addLinkedFiles)
                     [pubFiles addObject:[BDSKLinkedFile 
linkedFileWithURLString:string]];
-            } else if (eprint) {
-                // fill URL from arxiv ID if we did not find a link
-                string = [NSString stringWithFormat:@"https://%@/pdf/%@.pdf";, 
[url host], eprint];
-                if (addUrlField)
-                    [pubFields setValue:string forKey:BDSKUrlString];
-                if (addLinkedFiles)
-                    [pubFiles addObject:[BDSKLinkedFile 
linkedFileWithURLString:string]];
             }
         }
         
@@ -216,6 +208,12 @@
                 if (addLinkedFiles)
                     [pubFiles addObject:[BDSKLinkedFile 
linkedFileWithURLString:string]];
             }
+        } else if ((string = [pubFields objectForKey:@"Eprint"])) {
+            string = [NSString stringWithFormat:@"https://%@/pdf/%@.pdf";, [url 
host], string];
+            if (addUrlField)
+                [pubFields setValue:string forKey:BDSKUrlString];
+            if (addLinkedFiles)
+                [pubFiles addObject:[BDSKLinkedFile 
linkedFileWithURLString:string]];
         }
         
         // search for DOI

This was sent by the SourceForge.net collaborative development platform, the 
world's largest Open Source development site.



_______________________________________________
Bibdesk-commit mailing list
Bibdesk-commit@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bibdesk-commit