Revision: 22657
          http://sourceforge.net/p/bibdesk/svn/22657
Author:   hofman
Date:     2018-09-23 12:14:17 +0000 (Sun, 23 Sep 2018)
Log Message:
-----------
let container handle addition of identical objects

Modified Paths:
--------------
    trunk/bibdesk/BDSKAddCommand.m

Modified: trunk/bibdesk/BDSKAddCommand.m
===================================================================
--- trunk/bibdesk/BDSKAddCommand.m      2018-09-23 12:11:36 UTC (rev 22656)
+++ trunk/bibdesk/BDSKAddCommand.m      2018-09-23 12:14:17 UTC (rev 22657)
@@ -129,23 +129,13 @@
                     [self setScriptErrorNumber:NSArgumentsWrongScriptError];
                     [self setScriptErrorString:NSLocalizedString(@"Invalid 
container to add to", @"Error description")];
                 } else {
-                    NSArray *objects = [insertionContainer 
valueForKey:insertionKey];
-                    NSMutableArray *insertedObjects = [NSMutableArray array];
                     // insert using scripting KVC
                     if (insertionIndex >= 0) {
-                        for (id obj in [insertionObjects 
reverseObjectEnumerator]) {
-                            if ([objects indexOfObjectIdenticalTo:obj] == 
NSNotFound) {
-                                [insertionContainer insertValue:obj 
atIndex:insertionIndex inPropertyWithKey:insertionKey];
-                                [insertedObjects addObject:obj];
-                            }
-                        }
+                        for (id obj in [insertionObjects 
reverseObjectEnumerator])
+                            [insertionContainer insertValue:obj 
atIndex:insertionIndex inPropertyWithKey:insertionKey];
                     } else {
-                        for (id obj in insertionObjects) {
-                            if ([objects indexOfObjectIdenticalTo:obj] == 
NSNotFound) {
-                                [insertionContainer insertValue:obj 
inPropertyWithKey:insertionKey];
-                                [insertedObjects addObject:obj];
-                            }
-                        }
+                        for (id obj in insertionObjects)
+                            [insertionContainer insertValue:obj 
inPropertyWithKey:insertionKey];
                     }
                 }
             }

This was sent by the SourceForge.net collaborative development platform, the 
world's largest Open Source development site.



_______________________________________________
Bibdesk-commit mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/bibdesk-commit

Reply via email to