[Bibdesk-commit] SF.net SVN: bibdesk:[22775] trunk/bibdesk/BDSKParseFormatCommand.m

[hofman--- via Bibdesk-commit]

Revision: 22775
          http://sourceforge.net/p/bibdesk/svn/22775
Author:   hofman
Date:     2018-10-08 21:49:00 +0000 (Mon, 08 Oct 2018)
Log Message:
-----------
check index for parse format

Modified Paths:
--------------
    trunk/bibdesk/BDSKParseFormatCommand.m

Modified: trunk/bibdesk/BDSKParseFormatCommand.m
===================================================================
--- trunk/bibdesk/BDSKParseFormatCommand.m      2018-10-08 21:39:37 UTC (rev 
22774)
+++ trunk/bibdesk/BDSKParseFormatCommand.m      2018-10-08 21:49:00 UTC (rev 
22775)
@@ -143,9 +143,19 @@
     
     BOOL isFile = [field isEqualToString:BDSKLocalFileString];
     BOOL isFileField = [field isLocalFileField];
-    BDSKLinkedFile *file = isFile ? file = [[pub localFiles] objectAtIndex:i] 
: nil;
+    BDSKLinkedFile *file = nil;
     BOOL check = [[params objectForKey:@"check"] boolValue];
     
+    if (isFile) {
+        NSArray *files = [pub localFiles];
+        if (i < 0 || i >= (NSInteger)[files count]) {
+            [self setScriptErrorNumber:NSArgumentsWrongScriptError];
+            [self setScriptErrorString:@"Invalid local file index."];
+            return nil;
+        }
+        file = [files objectAtIndex:i];
+    }
+    
     if (check) {
         NSArray *requiredFields = [BDSKFormatParser 
requiredFieldsForFormat:formatString];
         

This was sent by the SourceForge.net collaborative development platform, the 
world's largest Open Source development site.



_______________________________________________
Bibdesk-commit mailing list
Bibdesk-commit@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bibdesk-commit