Revision: 24098
http://sourceforge.net/p/bibdesk/svn/24098
Author: hofman
Date: 2019-08-01 09:30:31 +0000 (Thu, 01 Aug 2019)
Log Message:
-----------
always use light appearance for preview progress indicator, as it is shown over
PDF content
Modified Paths:
--------------
trunk/bibdesk/BDSKPreviewer.m
trunk/bibdesk/NSColor_BDSKExtensions.h
trunk/bibdesk/NSColor_BDSKExtensions.m
Modified: trunk/bibdesk/BDSKPreviewer.m
===================================================================
--- trunk/bibdesk/BDSKPreviewer.m 2019-08-01 06:31:12 UTC (rev 24097)
+++ trunk/bibdesk/BDSKPreviewer.m 2019-08-01 09:30:31 UTC (rev 24098)
@@ -53,6 +53,7 @@
#import "BDSKPreferenceController.h"
#import "NSGeometry_BDSKExtensions.h"
#import "NSAlert_BDSKExtensions.h"
+#import "NSColor_BDSKExtensions.h"
#define BDSKPreviewPanelFrameAutosaveName @"BDSKPreviewPanel"
@@ -119,11 +120,15 @@
[[warningImageView image] drawInRect:targetRect fromRect:NSZeroRect
operation:NSCompositeSourceOver fraction:0.7];
}];
+
[warningImageView setImage:image];
[image release];
// we use threads, so better let the progressIndicator also use them
[progressIndicator setUsesThreadedAnimation:YES];
+ // always use light appearance, as it is shown over PDF content
+ BDSKSetHasLightAppearance(progressIndicator);
+
minSize.height += NSMinY([[progressIndicator superview] frame]);
[collapsibleView setMinSize:minSize];
[collapsibleView setCollapseEdges:BDSKMaxXEdgeMask | BDSKMaxYEdgeMask];
Modified: trunk/bibdesk/NSColor_BDSKExtensions.h
===================================================================
--- trunk/bibdesk/NSColor_BDSKExtensions.h 2019-08-01 06:31:12 UTC (rev
24097)
+++ trunk/bibdesk/NSColor_BDSKExtensions.h 2019-08-01 09:30:31 UTC (rev
24098)
@@ -40,6 +40,8 @@
extern BOOL BDSKHasDarkAppearance(id object);
+extern void BDSKSetHasDarkAppearance(id object);
+extern void BDSKSetHasLightAppearance(id object);
extern void BDSKRunWithAppearance(id object, void (^code)(void));
@interface NSColor (BDSKExtensions)
Modified: trunk/bibdesk/NSColor_BDSKExtensions.m
===================================================================
--- trunk/bibdesk/NSColor_BDSKExtensions.m 2019-08-01 06:31:12 UTC (rev
24097)
+++ trunk/bibdesk/NSColor_BDSKExtensions.m 2019-08-01 09:30:31 UTC (rev
24098)
@@ -86,6 +86,16 @@
return NO;
}
+void BDSKSetHasDarkAppearance(id object) {
+ if (RUNNING_AFTER(10_13) && [object
respondsToSelector:@selector(setAppearance:)])
+ [(id<NSAppearanceCustomization>)object setAppearance:[NSAppearance
appearanceNamed:@"NSAppearanceNameDarkAqua"]];
+}
+
+void BDSKSetHasLightAppearance(id object) {
+ if (RUNNING_AFTER(10_13) && [object
respondsToSelector:@selector(setAppearance:)])
+ [(id<NSAppearanceCustomization>)object setAppearance:[NSAppearance
appearanceNamed:@"NSAppearanceNameAqua"]];
+}
+
void BDSKRunWithAppearance(id object, void (^code)(void)) {
if (RUNNING_AFTER(10_13)) {
#pragma clang diagnostic push
This was sent by the SourceForge.net collaborative development platform, the
world's largest Open Source development site.
_______________________________________________
Bibdesk-commit mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/bibdesk-commit
