Revision: 27512 http://sourceforge.net/p/bibdesk/svn/27512 Author: hofman Date: 2022-05-31 22:33:16 +0000 (Tue, 31 May 2022) Log Message: ----------- define array of script hook names in preference pane as local variable
Modified Paths: -------------- trunk/bibdesk/BDSKScriptHook.h trunk/bibdesk/BDSKScriptHook.m trunk/bibdesk/BibPref_ScriptHooks.m Modified: trunk/bibdesk/BDSKScriptHook.h =================================================================== --- trunk/bibdesk/BDSKScriptHook.h 2022-05-31 15:06:37 UTC (rev 27511) +++ trunk/bibdesk/BDSKScriptHook.h 2022-05-31 22:33:16 UTC (rev 27512) @@ -63,8 +63,6 @@ NSDocument *document; } -+ (NSArray *)scriptHookNames; - + (BDSKScriptHook *)scriptHookWithUniqueID:(NSString *)uniqueID; + (BDSKScriptHook *)newWithName:(NSString *)name; Modified: trunk/bibdesk/BDSKScriptHook.m =================================================================== --- trunk/bibdesk/BDSKScriptHook.m 2022-05-31 15:06:37 UTC (rev 27511) +++ trunk/bibdesk/BDSKScriptHook.m 2022-05-31 22:33:16 UTC (rev 27512) @@ -68,25 +68,6 @@ static NSMutableDictionary *scriptHooks = nil; -+ (NSArray *)scriptHookNames { - static NSArray *scriptHookNames = nil; - if (scriptHookNames == nil) - scriptHookNames = [[NSArray alloc] initWithObjects:BDSKScriptHookNameChangeField, - BDSKScriptHookNameCloseEditorWindow, - BDSKScriptHookNameAddFile, - BDSKScriptHookNameRemoveFile, - BDSKScriptHookNameWillAutoFile, - BDSKScriptHookNameDidAutoFile, - BDSKScriptHookNameWillGenerateCiteKey, - BDSKScriptHookNameDidGenerateCiteKey, - BDSKScriptHookNameImportPublications, - BDSKScriptHookNameWillDeletePublications, - BDSKScriptHookNameSaveDocument, - BDSKScriptHookNameOpenDocument, - BDSKScriptHookNameRevertDocument, nil]; - return scriptHookNames; -} - + (BDSKScriptHook *)scriptHookWithUniqueID:(NSString *)uniqueID { return [scriptHooks objectForKey:uniqueID]; } Modified: trunk/bibdesk/BibPref_ScriptHooks.m =================================================================== --- trunk/bibdesk/BibPref_ScriptHooks.m 2022-05-31 15:06:37 UTC (rev 27511) +++ trunk/bibdesk/BibPref_ScriptHooks.m 2022-05-31 22:33:16 UTC (rev 27512) @@ -62,7 +62,20 @@ self = [super initWithRecord:aRecord forPreferenceController:aController]; if (self) { NSMutableArray *array = [[NSMutableArray alloc] init]; - for (NSString *name in [BDSKScriptHook scriptHookNames]) { + NSArray *scriptHookNames = [NSArray arrayWithObjects:BDSKScriptHookNameChangeField, + BDSKScriptHookNameCloseEditorWindow, + BDSKScriptHookNameAddFile, + BDSKScriptHookNameRemoveFile, + BDSKScriptHookNameWillAutoFile, + BDSKScriptHookNameDidAutoFile, + BDSKScriptHookNameWillGenerateCiteKey, + BDSKScriptHookNameDidGenerateCiteKey, + BDSKScriptHookNameImportPublications, + BDSKScriptHookNameWillDeletePublications, + BDSKScriptHookNameSaveDocument, + BDSKScriptHookNameOpenDocument, + BDSKScriptHookNameRevertDocument, nil]; + for (NSString *name in scriptHookNames) { BDSKScriptHookFile *file = [[BDSKScriptHookFile alloc] initWithName:name]; [array addObject:file]; [file release]; This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site. _______________________________________________ Bibdesk-commit mailing list Bibdesk-commit@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/bibdesk-commit