Revision: 27782
          http://sourceforge.net/p/bibdesk/svn/27782
Author:   hofman
Date:     2022-08-09 11:16:27 +0000 (Tue, 09 Aug 2022)
Log Message:
-----------
make sure favicon is not released before setting it

Modified Paths:
--------------
    trunk/bibdesk/BDSKWebView.m

Modified: trunk/bibdesk/BDSKWebView.m
===================================================================
--- trunk/bibdesk/BDSKWebView.m 2022-08-09 07:22:43 UTC (rev 27781)
+++ trunk/bibdesk/BDSKWebView.m 2022-08-09 11:16:27 UTC (rev 27782)
@@ -207,8 +207,10 @@
 - (void)retrieveFavicon {
     NSImage *icon = [[self class] faviconForURLString:[self mainFrameURL]];
     if (icon) {
-        [favicon release];
-        favicon = [icon retain];
+        if (icon != favicon) {
+            [favicon release];
+            favicon = [icon retain];
+        }
         if ([[self frameLoadDelegate] 
respondsToSelector:@selector(webView:didReceiveIcon:forFrame:)])
             [[self frameLoadDelegate] webView:self didReceiveIcon:favicon 
forFrame:[self mainFrame]];
         return;

This was sent by the SourceForge.net collaborative development platform, the 
world's largest Open Source development site.



_______________________________________________
Bibdesk-commit mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/bibdesk-commit

Reply via email to