Revision: 27911
http://sourceforge.net/p/bibdesk/svn/27911
Author: hofman
Date: 2022-09-20 09:30:28 +0000 (Tue, 20 Sep 2022)
Log Message:
-----------
remove waitUntilDone argument, it is always NOin practice
Modified Paths:
--------------
trunk/bibdesk/BDSKAsyncObject.h
trunk/bibdesk/BDSKAsyncObject.m
trunk/bibdesk/BDSKSharingClient.m
trunk/bibdesk/BDSKSharingServer.m
trunk/bibdesk/BDSKZoomGroupServer.m
Modified: trunk/bibdesk/BDSKAsyncObject.h
===================================================================
--- trunk/bibdesk/BDSKAsyncObject.h 2022-09-19 17:24:24 UTC (rev 27910)
+++ trunk/bibdesk/BDSKAsyncObject.h 2022-09-20 09:30:28 UTC (rev 27911)
@@ -68,6 +68,6 @@
// run loop flag; thread safe
@property (nonatomic, readonly) BOOL shouldKeepRunning;
-- (void)performSelectorOnLocalThread:(SEL)aSelector withObject:(id)arg
waitUntilDone:(BOOL)wait;
+- (void)performSelectorOnLocalThread:(SEL)aSelector withObject:(id)arg;
@end
Modified: trunk/bibdesk/BDSKAsyncObject.m
===================================================================
--- trunk/bibdesk/BDSKAsyncObject.m 2022-09-19 17:24:24 UTC (rev 27910)
+++ trunk/bibdesk/BDSKAsyncObject.m 2022-09-20 09:30:28 UTC (rev 27911)
@@ -85,9 +85,9 @@
[localThread start];
}
-- (void)performSelectorOnLocalThread:(SEL)aSelector withObject:(id)arg
waitUntilDone:(BOOL)wait {
+- (void)performSelectorOnLocalThread:(SEL)aSelector withObject:(id)arg {
if (localThread)
- [self performSelector:aSelector onThread:localThread withObject:arg
waitUntilDone:wait];
+ [self performSelector:aSelector onThread:localThread withObject:arg
waitUntilDone:NO];
}
#pragma mark Local Thread
@@ -153,7 +153,7 @@
// set the stop flag, so any long process (possibly with loops) knows it
can return
atomic_store(&shouldKeepRunning, NO);
// this is mainly to tickle the runloop on the local thread so it will
finish
- [self performSelectorOnLocalThread:@selector(stopRunning) withObject:nil
waitUntilDone:NO];
+ [self performSelectorOnLocalThread:@selector(stopRunning) withObject:nil];
BDSKDESTROY(localThread);
}
Modified: trunk/bibdesk/BDSKSharingClient.m
===================================================================
--- trunk/bibdesk/BDSKSharingClient.m 2022-09-19 17:24:24 UTC (rev 27910)
+++ trunk/bibdesk/BDSKSharingClient.m 2022-09-20 09:30:28 UTC (rev 27911)
@@ -125,7 +125,7 @@
- (void)retrievePublications {
[self setRetrieving:YES];
- [asyncClient performSelectorOnLocalThread:@selector(retrievePublications)
withObject:nil waitUntilDone:NO];
+ [asyncClient performSelectorOnLocalThread:@selector(retrievePublications)
withObject:nil];
}
- (void)setArchivedPublicationsAndMacros:(NSDictionary *)dictionary {
Modified: trunk/bibdesk/BDSKSharingServer.m
===================================================================
--- trunk/bibdesk/BDSKSharingServer.m 2022-09-19 17:24:24 UTC (rev 27910)
+++ trunk/bibdesk/BDSKSharingServer.m 2022-09-20 09:30:28 UTC (rev 27911)
@@ -255,7 +255,7 @@
// not the default connection here; we want to call our background thread,
but only if it's running
// add a hidden pref in case this traffic turns us into a bad network
citizen; manual updates will still work
if([asyncServer shouldKeepRunning] && [[NSUserDefaults
standardUserDefaults] boolForKey:BDSKDisableRemoteChangeNotificationsKey] == 0){
- [asyncServer
performSelectorOnLocalThread:@selector(notifyClientsOfChange) withObject:nil
waitUntilDone:NO];
+ [asyncServer
performSelectorOnLocalThread:@selector(notifyClientsOfChange) withObject:nil];
}
}
Modified: trunk/bibdesk/BDSKZoomGroupServer.m
===================================================================
--- trunk/bibdesk/BDSKZoomGroupServer.m 2022-09-19 17:24:24 UTC (rev 27910)
+++ trunk/bibdesk/BDSKZoomGroupServer.m 2022-09-20 09:30:28 UTC (rev 27911)
@@ -123,7 +123,7 @@
- (void)reset
{
if ([self isRetrieving]) {
- [self performSelectorOnLocalThread:@selector(terminateConnection)
withObject:nil waitUntilDone:NO];
+ [self performSelectorOnLocalThread:@selector(terminateConnection)
withObject:nil];
atomic_store(&flags.isRetrieving, NO);
}
atomic_store(&availableResults, 0);
@@ -141,7 +141,7 @@
atomic_store(&flags.failedDownload, NO);
atomic_store(&flags.isRetrieving, YES);
- [self performSelectorOnLocalThread:@selector(downloadWithSearchTerm:)
withObject:aSearchTerm waitUntilDone:NO];
+ [self performSelectorOnLocalThread:@selector(downloadWithSearchTerm:)
withObject:aSearchTerm];
}
- (void)setServerInfo:(BDSKServerInfo *)info;
This was sent by the SourceForge.net collaborative development platform, the
world's largest Open Source development site.
_______________________________________________
Bibdesk-commit mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/bibdesk-commit
