Revision: 27928
          http://sourceforge.net/p/bibdesk/svn/27928
Author:   hofman
Date:     2022-09-25 15:07:24 +0000 (Sun, 25 Sep 2022)
Log Message:
-----------
save password in keychain only from mutable server info

Modified Paths:
--------------
    trunk/bibdesk/BDSKServerInfo.m

Modified: trunk/bibdesk/BDSKServerInfo.m
===================================================================
--- trunk/bibdesk/BDSKServerInfo.m      2022-09-25 14:57:39 UTC (rev 27927)
+++ trunk/bibdesk/BDSKServerInfo.m      2022-09-25 15:07:24 UTC (rev 27928)
@@ -71,6 +71,9 @@
 @interface BDSKServerInfo ()
 @property (nonatomic, readonly) NSDictionary *optionsWithoutPassword;
 @property (nonatomic, readonly) NSString *passwordFromKeychain;
+@end
+
+@interface BDSKMutableServerInfo ()
 - (void)savePasswordInKeychain;
 @end
 
@@ -270,20 +273,6 @@
     return BDSKServerTypeEntrez;
 }
 
-- (void)savePasswordInKeychain {
-    if ([self isZoom] == NO && [self isISI] == NO)
-        return;
-    // don't get the password from the keychain
-    NSString *password = [[self options] objectForKey:PASSWORD_KEY];
-    if (password == nil)
-        return;
-    NSString *account = [self username];
-    NSString *server = [self isISI] ? ISI_SERVER : [self host];
-    if (account == nil || server == nil)
-        return;
-    [BDSKPasswordController addOrModifyPassword:password 
forKeychainServer:server port:[[self port] integerValue] account:account];
-}
-
 - (NSString *)passwordFromKeychain {
     if ([self isZoom] == NO && [self isISI] == NO)
         return nil;
@@ -464,4 +453,18 @@
     return isValid;
 }
 
+- (void)savePasswordInKeychain {
+    if ([self isZoom] == NO && [self isISI] == NO)
+        return;
+    // don't get the password from the keychain
+    NSString *password = [[self options] objectForKey:PASSWORD_KEY];
+    if (password == nil)
+        return;
+    NSString *account = [self username];
+    NSString *server = [self isISI] ? ISI_SERVER : [self host];
+    if (account == nil || server == nil)
+        return;
+    [BDSKPasswordController addOrModifyPassword:password 
forKeychainServer:server port:[[self port] integerValue] account:account];
+}
+
 @end

This was sent by the SourceForge.net collaborative development platform, the 
world's largest Open Source development site.



_______________________________________________
Bibdesk-commit mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/bibdesk-commit

Reply via email to