Revision: 28097
          http://sourceforge.net/p/bibdesk/svn/28097
Author:   hofman
Date:     2022-12-06 15:43:45 +0000 (Tue, 06 Dec 2022)
Log Message:
-----------
set warning image for cite key rather than (un)hiding, so it collapses when not 
shown

Modified Paths:
--------------
    trunk/bibdesk/BDSKEditor.m
    trunk/bibdesk/Base.lproj/BDSKEditor.xib

Modified: trunk/bibdesk/BDSKEditor.m
===================================================================
--- trunk/bibdesk/BDSKEditor.m  2022-12-06 07:30:14 UTC (rev 28096)
+++ trunk/bibdesk/BDSKEditor.m  2022-12-06 15:43:45 UTC (rev 28097)
@@ -3649,7 +3649,7 @@
         message = NSLocalizedString(@"The cite-key has not been set", @"Tool 
tip message");
     else if ([publication isValidCiteKey:[publication citeKey]] == NO)
         message = NSLocalizedString(@"This cite-key is a duplicate", @"Tool 
tip message");
-       [citeKeyWarningButton setHidden:message == nil];
+    [citeKeyWarningButton setImage:message ? [NSImage 
imageNamed:BDSKImageNameCautionIcon] : nil];
     [citeKeyWarningButton setToolTip:message];
        [citeKeyField setTextColor:(message ? [NSColor systemRedColor] : 
[NSColor controlTextColor])];
 }

Modified: trunk/bibdesk/Base.lproj/BDSKEditor.xib
===================================================================
--- trunk/bibdesk/Base.lproj/BDSKEditor.xib     2022-12-06 07:30:14 UTC (rev 
28096)
+++ trunk/bibdesk/Base.lproj/BDSKEditor.xib     2022-12-06 15:43:45 UTC (rev 
28097)
@@ -178,7 +178,7 @@
                                                             </textFieldCell>
                                                         </textField>
                                                         <textField 
verticalHuggingPriority="750" horizontalCompressionResistancePriority="250" 
translatesAutoresizingMaskIntoConstraints="NO" id="820">
-                                                            <rect key="frame" 
x="76" y="306" width="280" height="21"/>
+                                                            <rect key="frame" 
x="76" y="306" width="296" height="21"/>
                                                             <textFieldCell 
key="cell" scrollable="YES" lineBreakMode="clipping" selectable="YES" 
editable="YES" sendsActionOnEndEditing="YES" state="on" borderStyle="bezel" 
alignment="left" drawsBackground="YES" id="1009">
                                                                 
<customFormatter key="formatter" id="SBB-E6-GGd" 
customClass="BDSKCiteKeyFormatter"/>
                                                                 <font 
key="font" metaFont="system"/>
@@ -191,13 +191,13 @@
                                                                 <outlet 
property="delegate" destination="-2" id="930"/>
                                                             </connections>
                                                         </textField>
-                                                        <button hidden="YES" 
horizontalHuggingPriority="750" verticalHuggingPriority="750" 
translatesAutoresizingMaskIntoConstraints="NO" id="813">
-                                                            <rect key="frame" 
x="364" y="309" width="16" height="16"/>
+                                                        <button 
horizontalHuggingPriority="750" verticalHuggingPriority="750" 
translatesAutoresizingMaskIntoConstraints="NO" id="813">
+                                                            <rect key="frame" 
x="380" y="317" width="0.0" height="0.0"/>
                                                             <constraints>
                                                                 <constraint 
firstAttribute="width" secondItem="813" secondAttribute="height" 
multiplier="1:1" id="BLk-hX-XBh"/>
-                                                                <constraint 
firstAttribute="width" constant="16" id="sxT-GJ-i9d"/>
+                                                                <constraint 
firstAttribute="width" relation="lessThanOrEqual" constant="16" 
id="sxT-GJ-i9d"/>
                                                             </constraints>
-                                                            <buttonCell 
key="cell" type="square" bezelStyle="shadowlessSquare" image="BDSKCautionIcon" 
imagePosition="only" alignment="left" imageScaling="proportionallyDown" 
inset="2" id="1006">
+                                                            <buttonCell 
key="cell" type="square" bezelStyle="shadowlessSquare" imagePosition="only" 
alignment="left" imageScaling="proportionallyDown" inset="2" id="1006">
                                                                 <behavior 
key="behavior" lightByContents="YES"/>
                                                                 <font 
key="font" metaFont="label"/>
                                                             </buttonCell>
@@ -715,7 +715,6 @@
         </customView>
     </objects>
     <resources>
-        <image name="BDSKCautionIcon" width="128" height="128"/>
         <image name="NSActionTemplate" width="15" height="15"/>
         <image name="NSAddTemplate" width="14" height="13"/>
     </resources>

This was sent by the SourceForge.net collaborative development platform, the 
world's largest Open Source development site.



_______________________________________________
Bibdesk-commit mailing list
Bibdesk-commit@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bibdesk-commit

Reply via email to