Revision: 28256
          http://sourceforge.net/p/bibdesk/svn/28256
Author:   hofman
Date:     2023-05-22 16:32:37 +0000 (Mon, 22 May 2023)
Log Message:
-----------
check whether to autogenerate cite key before getting required fields

Modified Paths:
--------------
    trunk/bibdesk/BibItem.m

Modified: trunk/bibdesk/BibItem.m
===================================================================
--- trunk/bibdesk/BibItem.m     2023-05-22 16:28:43 UTC (rev 28255)
+++ trunk/bibdesk/BibItem.m     2023-05-22 16:32:37 UTC (rev 28256)
@@ -1104,10 +1104,14 @@
 
 - (BOOL)canAutogenerateCiteKey
 {
+    // see if it needs to be set (hasEmptyOrDefaultCiteKey)
+    if (NO == [self needsToAutogenerateCiteKey])
+        return NO;
+    
     NSArray *requiredFields = [[BDSKTypeManager sharedManager] 
requiredFieldsForCiteKey];
     
-    // see if it needs to be set (hasEmptyOrDefaultCiteKey)
-    if (nil == requiredFields || NO == [self needsToAutogenerateCiteKey])
+    // this should never happen
+    if (nil == requiredFields)
                return NO;
     
     // see if we have enough fields to generate it

This was sent by the SourceForge.net collaborative development platform, the 
world's largest Open Source development site.



_______________________________________________
Bibdesk-commit mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/bibdesk-commit

Reply via email to